Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2424)

Unified Diff: android_webview/native/aw_http_auth_handler.h

Issue 1492703004: Pass method parameters as JavaParamRef in android_webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: forgot to test compile unit tests before uploading, whoops Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/native/aw_http_auth_handler.h
diff --git a/android_webview/native/aw_http_auth_handler.h b/android_webview/native/aw_http_auth_handler.h
index 79b7406ec2c6e4521565214bb618320e4717037c..09f6ed1229abcd617fe42f7d897398bf00feb6fb 100644
--- a/android_webview/native/aw_http_auth_handler.h
+++ b/android_webview/native/aw_http_auth_handler.h
@@ -37,8 +37,11 @@ class AwHttpAuthHandler : public AwHttpAuthHandlerBase {
// from AwHttpAuthHandler
bool HandleOnUIThread(content::WebContents* web_contents) override;
- void Proceed(JNIEnv* env, jobject obj, jstring username, jstring password);
- void Cancel(JNIEnv* env, jobject obj);
+ void Proceed(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ const base::android::JavaParamRef<jstring>& username,
+ const base::android::JavaParamRef<jstring>& password);
+ void Cancel(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);
private:
scoped_refptr<AwLoginDelegate> login_delegate_;
« no previous file with comments | « android_webview/native/aw_contents_client_bridge_unittest.cc ('k') | android_webview/native/aw_http_auth_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698