Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Side by Side Diff: android_webview/native/aw_http_auth_handler.cc

Issue 1492703004: Pass method parameters as JavaParamRef in android_webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: forgot to test compile unit tests before uploading, whoops Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/native/aw_http_auth_handler.h" 5 #include "android_webview/native/aw_http_auth_handler.h"
6 6
7 #include "android_webview/browser/aw_login_delegate.h" 7 #include "android_webview/browser/aw_login_delegate.h"
8 #include "android_webview/native/aw_contents.h" 8 #include "android_webview/native/aw_contents.h"
9 #include "base/android/jni_android.h" 9 #include "base/android/jni_android.h"
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
(...skipping 20 matching lines...) Expand all
31 env, reinterpret_cast<intptr_t>(this), first_auth_attempt)); 31 env, reinterpret_cast<intptr_t>(this), first_auth_attempt));
32 } 32 }
33 33
34 AwHttpAuthHandler:: ~AwHttpAuthHandler() { 34 AwHttpAuthHandler:: ~AwHttpAuthHandler() {
35 DCHECK_CURRENTLY_ON(BrowserThread::UI); 35 DCHECK_CURRENTLY_ON(BrowserThread::UI);
36 Java_AwHttpAuthHandler_handlerDestroyed(base::android::AttachCurrentThread(), 36 Java_AwHttpAuthHandler_handlerDestroyed(base::android::AttachCurrentThread(),
37 http_auth_handler_.obj()); 37 http_auth_handler_.obj());
38 } 38 }
39 39
40 void AwHttpAuthHandler::Proceed(JNIEnv* env, 40 void AwHttpAuthHandler::Proceed(JNIEnv* env,
41 jobject obj, 41 const JavaParamRef<jobject>& obj,
42 jstring user, 42 const JavaParamRef<jstring>& user,
43 jstring password) { 43 const JavaParamRef<jstring>& password) {
44 DCHECK_CURRENTLY_ON(BrowserThread::UI); 44 DCHECK_CURRENTLY_ON(BrowserThread::UI);
45 if (login_delegate_.get()) { 45 if (login_delegate_.get()) {
46 login_delegate_->Proceed(ConvertJavaStringToUTF16(env, user), 46 login_delegate_->Proceed(ConvertJavaStringToUTF16(env, user),
47 ConvertJavaStringToUTF16(env, password)); 47 ConvertJavaStringToUTF16(env, password));
48 login_delegate_ = NULL; 48 login_delegate_ = NULL;
49 } 49 }
50 } 50 }
51 51
52 void AwHttpAuthHandler::Cancel(JNIEnv* env, jobject obj) { 52 void AwHttpAuthHandler::Cancel(JNIEnv* env, const JavaParamRef<jobject>& obj) {
53 DCHECK_CURRENTLY_ON(BrowserThread::UI); 53 DCHECK_CURRENTLY_ON(BrowserThread::UI);
54 if (login_delegate_.get()) { 54 if (login_delegate_.get()) {
55 login_delegate_->Cancel(); 55 login_delegate_->Cancel();
56 login_delegate_ = NULL; 56 login_delegate_ = NULL;
57 } 57 }
58 } 58 }
59 59
60 bool AwHttpAuthHandler::HandleOnUIThread(content::WebContents* web_contents) { 60 bool AwHttpAuthHandler::HandleOnUIThread(content::WebContents* web_contents) {
61 DCHECK(web_contents); 61 DCHECK(web_contents);
62 DCHECK_CURRENTLY_ON(BrowserThread::UI); 62 DCHECK_CURRENTLY_ON(BrowserThread::UI);
63 AwContents* aw_contents = AwContents::FromWebContents(web_contents); 63 AwContents* aw_contents = AwContents::FromWebContents(web_contents);
64 64
65 return aw_contents->OnReceivedHttpAuthRequest(http_auth_handler_, host_, 65 return aw_contents->OnReceivedHttpAuthRequest(http_auth_handler_, host_,
66 realm_); 66 realm_);
67 } 67 }
68 68
69 // static 69 // static
70 AwHttpAuthHandlerBase* AwHttpAuthHandlerBase::Create( 70 AwHttpAuthHandlerBase* AwHttpAuthHandlerBase::Create(
71 AwLoginDelegate* login_delegate, 71 AwLoginDelegate* login_delegate,
72 net::AuthChallengeInfo* auth_info, 72 net::AuthChallengeInfo* auth_info,
73 bool first_auth_attempt) { 73 bool first_auth_attempt) {
74 return new AwHttpAuthHandler(login_delegate, auth_info, first_auth_attempt); 74 return new AwHttpAuthHandler(login_delegate, auth_info, first_auth_attempt);
75 } 75 }
76 76
77 bool RegisterAwHttpAuthHandler(JNIEnv* env) { 77 bool RegisterAwHttpAuthHandler(JNIEnv* env) {
78 return RegisterNativesImpl(env); 78 return RegisterNativesImpl(env);
79 } 79 }
80 80
81 } // namespace android_webview 81 } // namespace android_webview
OLDNEW
« no previous file with comments | « android_webview/native/aw_http_auth_handler.h ('k') | android_webview/native/aw_message_port_service_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698