Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1492633007: Revert of Add option to draw wireframe batch bounds (Closed)

Created:
5 years ago by scroggo
Modified:
5 years ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add option to draw wireframe batch bounds (patchset #6 id:100001 of https://codereview.chromium.org/1494473005/ ) Reason for revert: Looks to be responsible for breaking builds e.g. https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-GPU-HD4000-x86_64-Debug/builds/3030/steps/dm/logs/stdio Original issue's description: > Add option to draw wireframe batch bounds > > Committed: https://skia.googlesource.com/skia/+/26489ef21ff5df33b8cb5943fddfd4604e203960 TBR=joshualitt@google.com,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/e2725f584095cd0a2cc5100fb6f1dc6a1740284e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -229 lines) Patch
M dm/DMGpuSupport.h View 2 chunks +5 lines, -4 lines 0 comments Download
M dm/DMSrcSink.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M include/gpu/GrContextOptions.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrDrawTarget.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 2 chunks +0 lines, -13 lines 0 comments Download
M src/gpu/GrGpu.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/batches/GrBatch.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/gpu/batches/GrClearBatch.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/batches/GrCopySurfaceBatch.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/batches/GrDiscardBatch.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/batches/GrDrawBatch.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/gpu/batches/GrStencilPathBatch.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.h View 3 chunks +0 lines, -11 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 7 chunks +5 lines, -168 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scroggo
Created Revert of Add option to draw wireframe batch bounds
5 years ago (2015-12-03 18:30:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492633007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492633007/1
5 years ago (2015-12-03 18:30:25 UTC) #2
commit-bot: I haz the power
5 years ago (2015-12-03 18:30:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e2725f584095cd0a2cc5100fb6f1dc6a1740284e

Powered by Google App Engine
This is Rietveld 408576698