Issue 1491383003: Disallow non-hyphenated-identifier tag names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1491383003: Disallow non-hyphenated-identifier tag names. (Closed)

Created:
5 years ago by nweiz

Modified:
5 years ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

Disallow non-hyphenated-identifier tag names. This provides forward-compatibility for when we eventually add support for full expressions when selecting tags. See #16 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/3d1eee701546836ea9219088d8d6fcc61cd0fd72

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+100 lines, -11 lines)			Patch
M	lib/src/backend/metadata.dart	View	3 chunks	+23 lines, -1 line	0 comments	Download
M	lib/src/backend/platform_selector/scanner.dart	View	3 chunks	+2 lines, -7 lines	0 comments	Download
M	lib/src/runner/parse_metadata.dart	View	1 chunk	+9 lines, -3 lines	0 comments	Download
M	lib/src/utils.dart	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	test/runner/tag_test.dart	View	1 chunk	+55 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

nweiz

5 years ago (2015-12-04 01:04:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3d1eee701546836ea9219088d8d6fcc61cd0fd72 (presubmit successful).