Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: lib/src/runner/parse_metadata.dart

Issue 1491383003: Disallow non-hyphenated-identifier tag names. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/backend/platform_selector/scanner.dart ('k') | lib/src/utils.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/parse_metadata.dart
diff --git a/lib/src/runner/parse_metadata.dart b/lib/src/runner/parse_metadata.dart
index 8e1e8f19a6421563a026f0728855ca8e1fc54062..8d4cd240f8cdd90b60538169135845a97b74326f 100644
--- a/lib/src/runner/parse_metadata.dart
+++ b/lib/src/runner/parse_metadata.dart
@@ -176,9 +176,15 @@ class _Parser {
_assertConstructorName(constructorName, 'Tags', annotation);
_assertArguments(annotation.arguments, 'Tags', annotation, positional: 1);
- return _parseList(annotation.arguments.arguments.first)
- .map((tagExpression) => _parseString(tagExpression).stringValue)
- .toSet();
+ return _parseList(annotation.arguments.arguments.first).map((tagExpression) {
+ var name = _parseString(tagExpression).stringValue;
+ if (name.contains(anchoredHyphenatedIdentifier)) return name;
+
+ throw new SourceSpanFormatException(
+ "Invalid tag name. Tags must be (optionally hyphenated) Dart "
+ "identifiers.",
+ _spanFor(tagExpression));
+ }).toSet();
}
/// Parses an `@OnPlatform` annotation.
« no previous file with comments | « lib/src/backend/platform_selector/scanner.dart ('k') | lib/src/utils.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698