Disallow non-hyphenated-identifier tag names.

test/runner/tag_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 @TestOn("vm")
 
 import 'package:scheduled_test/descriptor.dart' as d;
 import 'package:scheduled_test/scheduled_stream.dart';
 import 'package:scheduled_test/scheduled_test.dart';
 
@@ skipping 246 matching lines @@
 
       var test = runTest(["-p", "vm,content-shell", "test.dart"]);
       test.stdout.expect(consumeThrough(lines(
           'Warning: A tag was used that wasn\'t specified on the command '
             'line.\n'
           '  a was used in the test "foo"')));
       test.stdout.expect(never(startsWith("Warning:")));
       test.shouldExit(0);
     });
   });
+
+  group("invalid tags", () {
+    test("are disallowed by test()", () {
+      d.file("test.dart", """
+        import 'package:test/test.dart';
+
+        void main() {
+          test("foo", () {}, tags: "a b");
+        }
+      """).create();
+
+      var test = runTest(["test.dart"]);
+      test.stdout.expect(consumeThrough(
+          '  Failed to load "test.dart": Invalid argument(s): Invalid tag "a '
+            'b". Tags must be (optionally hyphenated) Dart identifiers.'));
+      test.shouldExit(1);
+    });
+
+    test("are disallowed by group()", () {
+      d.file("test.dart", """
+        import 'package:test/test.dart';
+
+        void main() {
+          group("group", () {
+            test("foo", () {});
+          }, tags: "a b");
+        }
+      """).create();
+
+      var test = runTest(["test.dart"]);
+      test.stdout.expect(consumeThrough(
+          '  Failed to load "test.dart": Invalid argument(s): Invalid tag "a '
+            'b". Tags must be (optionally hyphenated) Dart identifiers.'));
+      test.shouldExit(1);
+    });
+
+    test("are disallowed by @Tags()", () {
+      d.file("test.dart", """
+        @Tags(const ["a b"])
+
+        import 'package:test/test.dart';
+
+        void main() {
+          test("foo", () {});
+        }
+      """).create();
+
+      var test = runTest(["test.dart"]);
+      test.stdout.expect(consumeThrough(lines(
+          '  Failed to load "test.dart":\n'
+          '  Error on line 1, column 22: Invalid tag name. Tags must be '
+            '(optionally hyphenated) Dart identifiers.')));
+      test.shouldExit(1);
+    });
+  });
 }
 
 /// Returns a [StreamMatcher] that asserts that a test emits warnings for [tags]
 /// in order.
 StreamMatcher tagWarnings(List<String> tags) => inOrder(() sync* {
   yield consumeThrough(
       "Warning: ${tags.length == 1 ? 'A tag was' : 'Tags were'} used that "
         "${tags.length == 1 ? "wasn't" : "weren't"} specified on the command "
         "line.");
 
   for (var tag in tags) {
     yield consumeWhile(isNot(contains(" was used in")));
     yield consumeThrough(startsWith("  $tag was used in"));
   }
 
   // Consume until the end of the warning block, and assert that it has no
   // further tags than the ones we specified.
   yield consumeWhile(isNot(anyOf([contains(" was used in"), isEmpty])));
   yield isEmpty;
 }());
 
 /// Returns a [StreamMatcher] that matches the lines of [string] in order.
 StreamMatcher lines(String string) => inOrder(string.split("\n"));