Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 1489453003: jni: Pass method parameters as JavaParamRef in content. (Closed)

Created:
5 years ago by Torne
Modified:
5 years ago
Reviewers:
no sievers
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, avayvod+watch_chromium.org, nasko+codewatch_chromium.org, yzshen+watch_chromium.org, dmazzoni+watch_chromium.org, ben+mojo_chromium.org, mlamouri+watch-media_chromium.org, aboxhall+watch_chromium.org, jam, abarth-chromium, je_julie, darin-cc_chromium.org, jkarlin+watch_chromium.org, creis+watch_chromium.org, timvolodine, feature-media-reviews_chromium.org, yuzo+watch_chromium.org, mlamouri+watch-sensors_chromium.org, plundblad+watch_chromium.org, riju_, nektar+watch_chromium.org, Aaron Boodman, dtseng+watch_chromium.org, darin (slow to review), Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

jni: Pass method parameters as JavaParamRef in content. Pass all object parameters to JNI methods in JavaParamRef<> wrappers. This matches previous changes made to do this for JNI non-method functions. This change omits changes to speech as there are some less-trivial cases there which will be dealt with in a later CL. BUG=506850 Committed: https://crrev.com/e1bfee9a009140ffef7945a083cf1c66ac15def7 Cr-Commit-Position: refs/heads/master@{#362409}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1202 lines, -691 lines) Patch
M content/browser/accessibility/browser_accessibility_manager_android.h View 3 chunks +79 lines, -26 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_android.cc View 13 chunks +79 lines, -25 lines 0 comments Download
M content/browser/android/background_sync_network_observer_android.h View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/android/background_sync_network_observer_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/content_video_view.h View 2 chunks +16 lines, -7 lines 0 comments Download
M content/browser/android/content_video_view.cc View 3 chunks +16 lines, -9 lines 0 comments Download
M content/browser/android/content_view_core_impl.h View 2 chunks +166 lines, -100 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 19 chunks +172 lines, -116 lines 1 comment Download
M content/browser/android/content_view_render_view.h View 1 chunk +22 lines, -10 lines 0 comments Download
M content/browser/android/content_view_render_view.cc View 4 chunks +25 lines, -11 lines 0 comments Download
M content/browser/android/date_time_chooser_android.h View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/android/date_time_chooser_android.cc View 3 chunks +5 lines, -3 lines 1 comment Download
M content/browser/android/interstitial_page_delegate_android.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/android/interstitial_page_delegate_android.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M content/browser/android/tracing_controller_android.h View 1 chunk +10 lines, -6 lines 0 comments Download
M content/browser/android/tracing_controller_android.cc View 3 chunks +14 lines, -10 lines 0 comments Download
M content/browser/android/web_contents_observer_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/web_contents_observer_proxy.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/device_sensors/sensor_manager_android.h View 1 chunk +29 lines, -11 lines 0 comments Download
M content/browser/device_sensors/sensor_manager_android.cc View 6 chunks +28 lines, -11 lines 0 comments Download
M content/browser/frame_host/navigation_controller_android.h View 1 chunk +97 lines, -57 lines 0 comments Download
M content/browser/frame_host/navigation_controller_android.cc View 8 chunks +79 lines, -55 lines 0 comments Download
M content/browser/media/android/media_session.h View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/media/android/media_session.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/mojo/service_registry_android.h View 1 chunk +15 lines, -10 lines 0 comments Download
M content/browser/mojo/service_registry_android.cc View 2 chunks +15 lines, -12 lines 0 comments Download
M content/browser/renderer_host/ime_adapter_android.h View 1 chunk +36 lines, -17 lines 0 comments Download
M content/browser/renderer_host/ime_adapter_android.cc View 9 chunks +38 lines, -20 lines 0 comments Download
M content/browser/time_zone_monitor_android.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/time_zone_monitor_android.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_android.h View 1 chunk +123 lines, -82 lines 0 comments Download
M content/browser/web_contents/web_contents_android.cc View 11 chunks +103 lines, -73 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Torne
Automated changes except for the parts called out in comments: https://codereview.chromium.org/1489453003/diff/1/content/browser/android/content_view_core_impl.cc File content/browser/android/content_view_core_impl.cc (right): https://codereview.chromium.org/1489453003/diff/1/content/browser/android/content_view_core_impl.cc#newcode1216 ...
5 years ago (2015-11-30 11:47:06 UTC) #2
no sievers
lgtm
5 years ago (2015-11-30 22:54:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489453003/1
5 years ago (2015-12-01 12:51:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 14:05:08 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-01 14:06:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1bfee9a009140ffef7945a083cf1c66ac15def7
Cr-Commit-Position: refs/heads/master@{#362409}

Powered by Google App Engine
This is Rietveld 408576698