content/browser/android/interstitial_page_delegate_android.h - Issue 1489453003: jni: Pass method parameters as JavaParamRef in content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/interstitial_page_delegate_android.h

Issue 1489453003: jni: Pass method parameters as JavaParamRef in content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/android/date_time_chooser_android.cc ('K') | « content/browser/android/date_time_chooser_android.cc ('k') | content/browser/android/interstitial_page_delegate_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/interstitial_page_delegate_android.h

diff --git a/content/browser/android/interstitial_page_delegate_android.h b/content/browser/android/interstitial_page_delegate_android.h

index bd28d381c9dfb4d0d166a746959780d8d45d11f2..69816b60ed7b4a0b4b98f5993c718f758e4662f5 100644

--- a/content/browser/android/interstitial_page_delegate_android.h

+++ b/content/browser/android/interstitial_page_delegate_android.h

@@ -31,8 +31,9 @@ class InterstitialPageDelegateAndroid : public InterstitialPageDelegate {

void set_interstitial_page(InterstitialPage* page) { page_ = page; }

// Methods called from Java.

- void Proceed(JNIEnv* env, jobject obj);

- void DontProceed(JNIEnv* env, jobject obj);

+ void Proceed(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);

+ void DontProceed(JNIEnv* env,

+ const base::android::JavaParamRef<jobject>& obj);

// Implementation of InterstitialPageDelegate

std::string GetHTMLContents() override;