jni: Pass method parameters as JavaParamRef in content.

content/browser/android/date_time_chooser_android.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/date_time_chooser_android.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/i18n/char_iterator.h"
 #include "content/common/date_time_suggestion.h"
 #include "content/common/view_messages.h"
 #include "content/public/browser/render_view_host.h"
 #include "jni/DateTimeChooserAndroid_jni.h"
 #include "third_party/icu/source/common/unicode/uchar.h"
 #include "third_party/icu/source/common/unicode/unistr.h"
 #include "ui/android/window_android.h"
 
 using base::android::AttachCurrentThread;
 using base::android::ConvertJavaStringToUTF16;
 using base::android::ConvertUTF8ToJavaString;
 using base::android::ConvertUTF16ToJavaString;
+using base::android::JavaRef;
 
 
 namespace {
 
 base::string16 SanitizeSuggestionString(const base::string16& string) {
   base::string16 trimmed = string.substr(0, 255);
   icu::UnicodeString sanitized;
   base::i18n::UTF16CharIterator sanitized_iterator(&trimmed);
   while (!sanitized_iterator.end()) {
     UChar c = sanitized_iterator.get();
@@ skipping 11 matching lines @@
 
 // DateTimeChooserAndroid implementation
 DateTimeChooserAndroid::DateTimeChooserAndroid()
   : host_(NULL) {
 }
 
 DateTimeChooserAndroid::~DateTimeChooserAndroid() {
 }
 
 void DateTimeChooserAndroid::ReplaceDateTime(JNIEnv* env,
-                                             jobject,
+                                             const JavaRef<jobject>&,

[Torne, 2015/11/30 11:47:06]

I'm using JavaRef instead of JavaParamRef in this file to allow the call on line
105 to work. The ultimate goal is to use JavaRef everywhere, and JavaParamRef is
just an intermediate step to allow incremental migration (it has an implicit
conversion back to jobject, which isn't needed here), so skipping ahead here is
okay :)

                                              jdouble value) {
   host_->Send(new ViewMsg_ReplaceDateTime(host_->GetRoutingID(), value));
 }
 
-void DateTimeChooserAndroid::CancelDialog(JNIEnv* env, jobject) {
+void DateTimeChooserAndroid::CancelDialog(JNIEnv* env,
+                                          const JavaRef<jobject>&) {
   host_->Send(new ViewMsg_CancelDateTimeDialog(host_->GetRoutingID()));
 }
 
 void DateTimeChooserAndroid::ShowDialog(
     gfx::NativeWindow native_window,
     RenderViewHost* host,
     ui::TextInputType dialog_type,
     double dialog_value,
     double min,
     double max,
@@ skipping 24 matching lines @@
       env,
       native_window->GetJavaObject().obj(),
       reinterpret_cast<intptr_t>(this),
       dialog_type,
       dialog_value,
       min,
       max,
       step,
       suggestions_array.obj()));
   if (j_date_time_chooser_.is_null())
-    ReplaceDateTime(env, j_date_time_chooser_.obj(), dialog_value);
+    ReplaceDateTime(env, j_date_time_chooser_, dialog_value);
 }
 
 // ----------------------------------------------------------------------------
 // Native JNI methods
 // ----------------------------------------------------------------------------
 bool RegisterDateTimeChooserAndroid(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace content