jni: Pass method parameters as JavaParamRef in content.

content/browser/android/content_view_core_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/content_view_core_impl.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
 #include "base/android/scoped_java_ref.h"
@@ skipping 239 matching lines @@
   JNIEnv* env = base::android::AttachCurrentThread();
   ScopedJavaLocalRef<jobject> j_obj = java_ref_.get(env);
   java_ref_.reset();
   if (!j_obj.is_null()) {
     Java_ContentViewCore_onNativeContentViewCoreDestroyed(
         env, j_obj.obj(), reinterpret_cast<intptr_t>(this));
   }
 }
 
 base::android::ScopedJavaLocalRef<jobject>
-ContentViewCoreImpl::GetWebContentsAndroid(JNIEnv* env, jobject obj) {
+ContentViewCoreImpl::GetWebContentsAndroid(JNIEnv* env,
+                                           const JavaParamRef<jobject>& obj) {
   return web_contents_->GetJavaWebContents();
 }
 
 base::android::ScopedJavaLocalRef<jobject>
-ContentViewCoreImpl::GetJavaWindowAndroid(JNIEnv* env, jobject obj) {
+ContentViewCoreImpl::GetJavaWindowAndroid(JNIEnv* env,
+                                          const JavaParamRef<jobject>& obj) {
   if (!window_android_)
     return ScopedJavaLocalRef<jobject>();
   return window_android_->GetJavaObject();
 }
 
-void ContentViewCoreImpl::OnJavaContentViewCoreDestroyed(JNIEnv* env,
-                                                         jobject obj) {
+void ContentViewCoreImpl::OnJavaContentViewCoreDestroyed(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& obj) {
   DCHECK(env->IsSameObject(java_ref_.get(env).obj(), obj));
   java_ref_.reset();
   // Java peer has gone, ContentViewCore is not functional and waits to
   // be destroyed with WebContents.
   // We need to reset WebContentsViewAndroid's reference, otherwise, there
   // could have call in when swapping the WebContents,
   // see http://crbug.com/383939 .
   DCHECK(web_contents_);
   static_cast<WebContentsViewAndroid*>(
       static_cast<WebContentsImpl*>(web_contents_)->GetView())->
@@ skipping 521 matching lines @@
 }
 
 const scoped_refptr<cc::Layer>& ContentViewCoreImpl::GetLayer() const {
   return root_layer_;
 }
 
 // ----------------------------------------------------------------------------
 // Methods called from Java via JNI
 // ----------------------------------------------------------------------------
 
-void ContentViewCoreImpl::SelectPopupMenuItems(JNIEnv* env,
-                                               jobject obj,
-                                               jlong selectPopupSourceFrame,
-                                               jintArray indices) {
+void ContentViewCoreImpl::SelectPopupMenuItems(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& obj,
+    jlong selectPopupSourceFrame,
+    const JavaParamRef<jintArray>& indices) {
   RenderFrameHostImpl* rfhi =
       reinterpret_cast<RenderFrameHostImpl*>(selectPopupSourceFrame);
   DCHECK(rfhi);
   if (indices == NULL) {
     rfhi->DidCancelPopupMenu();
     return;
   }
 
   int selected_count = env->GetArrayLength(indices);
   std::vector<int> selected_indices;
   jint* indices_ptr = env->GetIntArrayElements(indices, NULL);
   for (int i = 0; i < selected_count; ++i)
     selected_indices.push_back(indices_ptr[i]);
   env->ReleaseIntArrayElements(indices, indices_ptr, JNI_ABORT);
   rfhi->DidSelectPopupMenuItems(selected_indices);
 }
 
 WebContents* ContentViewCoreImpl::GetWebContents() const {
   return web_contents_;
 }
 
-void ContentViewCoreImpl::SetFocus(JNIEnv* env, jobject obj, jboolean focused) {
+void ContentViewCoreImpl::SetFocus(JNIEnv* env,
+                                   const JavaParamRef<jobject>& obj,
+                                   jboolean focused) {
   SetFocusInternal(focused);
 }
 
 void ContentViewCoreImpl::SetFocusInternal(bool focused) {
   if (!GetRenderWidgetHostViewAndroid())
     return;
 
   if (focused)
     GetRenderWidgetHostViewAndroid()->Focus();
   else
     GetRenderWidgetHostViewAndroid()->Blur();
 }
 
-void ContentViewCoreImpl::SendOrientationChangeEvent(JNIEnv* env,
-                                                     jobject obj,
-                                                     jint orientation) {
+void ContentViewCoreImpl::SendOrientationChangeEvent(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& obj,
+    jint orientation) {
   if (device_orientation_ != orientation) {
     device_orientation_ = orientation;
     SendOrientationChangeEventInternal();
   }
 }
 
-jboolean ContentViewCoreImpl::OnTouchEvent(JNIEnv* env,
-                                           jobject obj,
-                                           jobject motion_event,
-                                           jlong time_ms,
-                                           jint android_action,
-                                           jint pointer_count,
-                                           jint history_size,
-                                           jint action_index,
-                                           jfloat pos_x_0,
-                                           jfloat pos_y_0,
-                                           jfloat pos_x_1,
-                                           jfloat pos_y_1,
-                                           jint pointer_id_0,
-                                           jint pointer_id_1,
-                                           jfloat touch_major_0,
-                                           jfloat touch_major_1,
-                                           jfloat touch_minor_0,
-                                           jfloat touch_minor_1,
-                                           jfloat orientation_0,
-                                           jfloat orientation_1,
-                                           jfloat tilt_0,
-                                           jfloat tilt_1,
-                                           jfloat raw_pos_x,
-                                           jfloat raw_pos_y,
-                                           jint android_tool_type_0,
-                                           jint android_tool_type_1,
-                                           jint android_button_state,
-                                           jint android_meta_state,
-                                           jboolean is_touch_handle_event) {
+jboolean ContentViewCoreImpl::OnTouchEvent(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& obj,
+    const JavaParamRef<jobject>& motion_event,
+    jlong time_ms,
+    jint android_action,
+    jint pointer_count,
+    jint history_size,
+    jint action_index,
+    jfloat pos_x_0,
+    jfloat pos_y_0,
+    jfloat pos_x_1,
+    jfloat pos_y_1,
+    jint pointer_id_0,
+    jint pointer_id_1,
+    jfloat touch_major_0,
+    jfloat touch_major_1,
+    jfloat touch_minor_0,
+    jfloat touch_minor_1,
+    jfloat orientation_0,
+    jfloat orientation_1,
+    jfloat tilt_0,
+    jfloat tilt_1,
+    jfloat raw_pos_x,
+    jfloat raw_pos_y,
+    jint android_tool_type_0,
+    jint android_tool_type_1,
+    jint android_button_state,
+    jint android_meta_state,
+    jboolean is_touch_handle_event) {
   RenderWidgetHostViewAndroid* rwhv = GetRenderWidgetHostViewAndroid();
   // Avoid synthesizing a touch event if it cannot be forwarded.
   if (!rwhv)
     return false;
 
   ui::MotionEventAndroid::Pointer pointer0(pointer_id_0,
                                        pos_x_0,
                                        pos_y_0,
                                        touch_major_0,
                                        touch_minor_0,
@@ skipping 24 matching lines @@
                            pointer1);
 
   return is_touch_handle_event ? rwhv->OnTouchHandleEvent(event)
                                : rwhv->OnTouchEvent(event);
 }
 
 float ContentViewCoreImpl::GetDpiScale() const {
   return dpi_scale_;
 }
 
-jboolean ContentViewCoreImpl::SendMouseMoveEvent(JNIEnv* env,
-                                                 jobject obj,
-                                                 jlong time_ms,
-                                                 jfloat x,
-                                                 jfloat y) {
+jboolean ContentViewCoreImpl::SendMouseMoveEvent(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& obj,
+    jlong time_ms,
+    jfloat x,
+    jfloat y) {
   RenderWidgetHostViewAndroid* rwhv = GetRenderWidgetHostViewAndroid();
   if (!rwhv)
     return false;
 
   blink::WebMouseEvent event = WebMouseEventBuilder::Build(
       WebInputEvent::MouseMove,
       blink::WebMouseEvent::ButtonNone,
       time_ms / 1000.0, x / dpi_scale(), y / dpi_scale(), 0, 1);
 
   rwhv->SendMouseEvent(event);
   return true;
 }
 
-jboolean ContentViewCoreImpl::SendMouseWheelEvent(JNIEnv* env,
-                                                  jobject obj,
-                                                  jlong time_ms,
-                                                  jfloat x,
-                                                  jfloat y,
-                                                  jfloat ticks_x,
-                                                  jfloat ticks_y,
-                                                  jfloat pixels_per_tick) {
+jboolean ContentViewCoreImpl::SendMouseWheelEvent(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& obj,
+    jlong time_ms,
+    jfloat x,
+    jfloat y,
+    jfloat ticks_x,
+    jfloat ticks_y,
+    jfloat pixels_per_tick) {
   RenderWidgetHostViewAndroid* rwhv = GetRenderWidgetHostViewAndroid();
   if (!rwhv)
     return false;
 
   if (!ticks_x && !ticks_y)
     return false;
 
   blink::WebMouseWheelEvent event = WebMouseWheelEventBuilder::Build(
       ticks_x, ticks_y, pixels_per_tick / dpi_scale(), time_ms / 1000.0,
       x / dpi_scale(), y / dpi_scale());
 
   rwhv->SendMouseWheelEvent(event);
   return true;
 }
 
 WebGestureEvent ContentViewCoreImpl::MakeGestureEvent(
     WebInputEvent::Type type, int64 time_ms, float x, float y) const {
   return WebGestureEventBuilder::Build(
       type, time_ms / 1000.0, x / dpi_scale(), y / dpi_scale());
 }
 
 void ContentViewCoreImpl::SendGestureEvent(
     const blink::WebGestureEvent& event) {
   RenderWidgetHostViewAndroid* rwhv = GetRenderWidgetHostViewAndroid();
   if (rwhv)
     rwhv->SendGestureEvent(event);
 }
 
 void ContentViewCoreImpl::ScrollBegin(JNIEnv* env,
-                                      jobject obj,
+                                      const JavaParamRef<jobject>& obj,
                                       jlong time_ms,
                                       jfloat x,
                                       jfloat y,
                                       jfloat hintx,
                                       jfloat hinty,
                                       jboolean target_viewport) {
   WebGestureEvent event = MakeGestureEvent(
       WebInputEvent::GestureScrollBegin, time_ms, x, y);
   event.data.scrollBegin.deltaXHint = hintx / dpi_scale();
   event.data.scrollBegin.deltaYHint = hinty / dpi_scale();
   event.data.scrollBegin.targetViewport = target_viewport;
 
   SendGestureEvent(event);
 }
 
-void ContentViewCoreImpl::ScrollEnd(JNIEnv* env, jobject obj, jlong time_ms) {
+void ContentViewCoreImpl::ScrollEnd(JNIEnv* env,
+                                    const JavaParamRef<jobject>& obj,
+                                    jlong time_ms) {
   WebGestureEvent event = MakeGestureEvent(
       WebInputEvent::GestureScrollEnd, time_ms, 0, 0);
   SendGestureEvent(event);
 }
 
-void ContentViewCoreImpl::ScrollBy(JNIEnv* env, jobject obj, jlong time_ms,
-                                   jfloat x, jfloat y, jfloat dx, jfloat dy) {
+void ContentViewCoreImpl::ScrollBy(JNIEnv* env,
+                                   const JavaParamRef<jobject>& obj,
+                                   jlong time_ms,
+                                   jfloat x,
+                                   jfloat y,
+                                   jfloat dx,
+                                   jfloat dy) {
   WebGestureEvent event = MakeGestureEvent(
       WebInputEvent::GestureScrollUpdate, time_ms, x, y);
   event.data.scrollUpdate.deltaX = -dx / dpi_scale();
   event.data.scrollUpdate.deltaY = -dy / dpi_scale();
 
   SendGestureEvent(event);
 }
 
 void ContentViewCoreImpl::FlingStart(JNIEnv* env,
-                                     jobject obj,
+                                     const JavaParamRef<jobject>& obj,
                                      jlong time_ms,
                                      jfloat x,
                                      jfloat y,
                                      jfloat vx,
                                      jfloat vy,
                                      jboolean target_viewport) {
   WebGestureEvent event = MakeGestureEvent(
       WebInputEvent::GestureFlingStart, time_ms, x, y);
   event.data.flingStart.velocityX = vx / dpi_scale();
   event.data.flingStart.velocityY = vy / dpi_scale();
   event.data.flingStart.targetViewport = target_viewport;
 
   SendGestureEvent(event);
 }
 
-void ContentViewCoreImpl::FlingCancel(JNIEnv* env, jobject obj, jlong time_ms) {
+void ContentViewCoreImpl::FlingCancel(JNIEnv* env,
+                                      const JavaParamRef<jobject>& obj,
+                                      jlong time_ms) {
   WebGestureEvent event = MakeGestureEvent(
       WebInputEvent::GestureFlingCancel, time_ms, 0, 0);
   event.data.flingCancel.preventBoosting = true;
 
   SendGestureEvent(event);
 }
 
-void ContentViewCoreImpl::SingleTap(JNIEnv* env, jobject obj, jlong time_ms,
-                                    jfloat x, jfloat y) {
+void ContentViewCoreImpl::SingleTap(JNIEnv* env,
+                                    const JavaParamRef<jobject>& obj,
+                                    jlong time_ms,
+                                    jfloat x,
+                                    jfloat y) {
   // Tap gestures should always be preceded by a TapDown, ensuring consistency
   // with the touch-based gesture detection pipeline.
   WebGestureEvent tap_down_event = MakeGestureEvent(
       WebInputEvent::GestureTapDown, time_ms, x, y);
   tap_down_event.data.tap.tapCount = 1;
   SendGestureEvent(tap_down_event);
 
   WebGestureEvent tap_event = MakeGestureEvent(
       WebInputEvent::GestureTap, time_ms, x, y);
   tap_event.data.tap.tapCount = 1;
   SendGestureEvent(tap_event);
 }
 
-void ContentViewCoreImpl::DoubleTap(JNIEnv* env, jobject obj, jlong time_ms,
-                                    jfloat x, jfloat y) {
+void ContentViewCoreImpl::DoubleTap(JNIEnv* env,
+                                    const JavaParamRef<jobject>& obj,
+                                    jlong time_ms,
+                                    jfloat x,
+                                    jfloat y) {
   WebGestureEvent event = MakeGestureEvent(
       WebInputEvent::GestureDoubleTap, time_ms, x, y);
   // Set the tap count to 1 even for DoubleTap, in order to be consistent with
   // double tap behavior on a mobile viewport. See crbug.com/234986 for context.
   event.data.tap.tapCount = 1;
 
   SendGestureEvent(event);
 }
 
-void ContentViewCoreImpl::LongPress(JNIEnv* env, jobject obj, jlong time_ms,
-                                    jfloat x, jfloat y) {
+void ContentViewCoreImpl::LongPress(JNIEnv* env,
+                                    const JavaParamRef<jobject>& obj,
+                                    jlong time_ms,
+                                    jfloat x,
+                                    jfloat y) {
   WebGestureEvent event = MakeGestureEvent(
       WebInputEvent::GestureLongPress, time_ms, x, y);
 
   SendGestureEvent(event);
 }
 
-void ContentViewCoreImpl::PinchBegin(JNIEnv* env, jobject obj, jlong time_ms,
-                                     jfloat x, jfloat y) {
+void ContentViewCoreImpl::PinchBegin(JNIEnv* env,
+                                     const JavaParamRef<jobject>& obj,
+                                     jlong time_ms,
+                                     jfloat x,
+                                     jfloat y) {
   WebGestureEvent event = MakeGestureEvent(
       WebInputEvent::GesturePinchBegin, time_ms, x, y);
   SendGestureEvent(event);
 }
 
-void ContentViewCoreImpl::PinchEnd(JNIEnv* env, jobject obj, jlong time_ms) {
+void ContentViewCoreImpl::PinchEnd(JNIEnv* env,
+                                   const JavaParamRef<jobject>& obj,
+                                   jlong time_ms) {
   WebGestureEvent event = MakeGestureEvent(
       WebInputEvent::GesturePinchEnd, time_ms, 0, 0);
   SendGestureEvent(event);
 }
 
-void ContentViewCoreImpl::PinchBy(JNIEnv* env, jobject obj, jlong time_ms,
-                                  jfloat anchor_x, jfloat anchor_y,
+void ContentViewCoreImpl::PinchBy(JNIEnv* env,
+                                  const JavaParamRef<jobject>& obj,
+                                  jlong time_ms,
+                                  jfloat anchor_x,
+                                  jfloat anchor_y,
                                   jfloat delta) {
   WebGestureEvent event = MakeGestureEvent(
       WebInputEvent::GesturePinchUpdate, time_ms, anchor_x, anchor_y);
   event.data.pinchUpdate.scale = delta;
 
   SendGestureEvent(event);
 }
 
-void ContentViewCoreImpl::SelectBetweenCoordinates(JNIEnv* env, jobject obj,
-                                                   jfloat x1, jfloat y1,
-                                                   jfloat x2, jfloat y2) {
+void ContentViewCoreImpl::SelectBetweenCoordinates(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& obj,
+    jfloat x1,
+    jfloat y1,
+    jfloat x2,
+    jfloat y2) {
   SelectBetweenCoordinates(gfx::PointF(x1 / dpi_scale(), y1 / dpi_scale()),
                            gfx::PointF(x2 / dpi_scale(), y2 / dpi_scale()));
 }
 
-void ContentViewCoreImpl::MoveCaret(JNIEnv* env, jobject obj,
-                                    jfloat x, jfloat y) {
+void ContentViewCoreImpl::MoveCaret(JNIEnv* env,
+                                    const JavaParamRef<jobject>& obj,
+                                    jfloat x,
+                                    jfloat y) {
   RenderWidgetHostViewAndroid* rwhv = GetRenderWidgetHostViewAndroid();
   if (rwhv)
     rwhv->MoveCaret(gfx::Point(x / dpi_scale_, y / dpi_scale_));
 }
 
-void ContentViewCoreImpl::DismissTextHandles(JNIEnv* env, jobject obj) {
+void ContentViewCoreImpl::DismissTextHandles(JNIEnv* env,
+                                             const JavaParamRef<jobject>& obj) {
   RenderWidgetHostViewAndroid* rwhv = GetRenderWidgetHostViewAndroid();
   if (rwhv)
     rwhv->DismissTextHandles();
 }
 
-void ContentViewCoreImpl::SetTextHandlesTemporarilyHidden(JNIEnv* env,
-                                                          jobject obj,
-                                                          jboolean hidden) {
+void ContentViewCoreImpl::SetTextHandlesTemporarilyHidden(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& obj,
+    jboolean hidden) {
   RenderWidgetHostViewAndroid* rwhv = GetRenderWidgetHostViewAndroid();
   if (rwhv)
     rwhv->SetTextHandlesTemporarilyHidden(hidden);
 }
 
-void ContentViewCoreImpl::ResetGestureDetection(JNIEnv* env, jobject obj) {
+void ContentViewCoreImpl::ResetGestureDetection(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& obj) {
   RenderWidgetHostViewAndroid* rwhv = GetRenderWidgetHostViewAndroid();
   if (rwhv)
     rwhv->ResetGestureDetection();
 }
 
-void ContentViewCoreImpl::SetDoubleTapSupportEnabled(JNIEnv* env,
-                                                     jobject obj,
-                                                     jboolean enabled) {
+void ContentViewCoreImpl::SetDoubleTapSupportEnabled(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& obj,
+    jboolean enabled) {
   RenderWidgetHostViewAndroid* rwhv = GetRenderWidgetHostViewAndroid();
   if (rwhv)
     rwhv->SetDoubleTapSupportEnabled(enabled);
 }
 
-void ContentViewCoreImpl::SetMultiTouchZoomSupportEnabled(JNIEnv* env,
-                                                          jobject obj,
-                                                          jboolean enabled) {
+void ContentViewCoreImpl::SetMultiTouchZoomSupportEnabled(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& obj,
+    jboolean enabled) {
   RenderWidgetHostViewAndroid* rwhv = GetRenderWidgetHostViewAndroid();
   if (rwhv)
     rwhv->SetMultiTouchZoomSupportEnabled(enabled);
 }
 
 void ContentViewCoreImpl::SetAllowJavascriptInterfacesInspection(
     JNIEnv* env,
-    jobject obj,
+    const JavaParamRef<jobject>& obj,
     jboolean allow) {
   java_bridge_dispatcher_host_->SetAllowObjectContentsInspection(allow);
 }
 
 void ContentViewCoreImpl::AddJavascriptInterface(
     JNIEnv* env,
-    jobject /* obj */,
-    jobject object,
-    jstring name,
-    jclass safe_annotation_clazz) {
-  ScopedJavaLocalRef<jobject> scoped_object(env, object);
-  ScopedJavaLocalRef<jclass> scoped_clazz(env, safe_annotation_clazz);
+    const JavaParamRef<jobject>& /* obj */,
+    const JavaParamRef<jobject>& object,
+    const JavaParamRef<jstring>& name,
+    const JavaParamRef<jclass>& safe_annotation_clazz) {
   java_bridge_dispatcher_host_->AddNamedObject(
-      ConvertJavaStringToUTF8(env, name), scoped_object, scoped_clazz);
+      ConvertJavaStringToUTF8(env, name), object, safe_annotation_clazz);

[Torne, 2015/11/30 11:47:06]

manual change: no need to construct ScopedJavaLocalRefs any more as the
parameters are already JavaRefs.

 }
 
-void ContentViewCoreImpl::RemoveJavascriptInterface(JNIEnv* env,
-                                                    jobject /* obj */,
-                                                    jstring name) {
+void ContentViewCoreImpl::RemoveJavascriptInterface(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& /* obj */,
+    const JavaParamRef<jstring>& name) {
   java_bridge_dispatcher_host_->RemoveNamedObject(
       ConvertJavaStringToUTF8(env, name));
 }
 
-void ContentViewCoreImpl::WasResized(JNIEnv* env, jobject obj) {
+void ContentViewCoreImpl::WasResized(JNIEnv* env,
+                                     const JavaParamRef<jobject>& obj) {
   RenderWidgetHostViewAndroid* view = GetRenderWidgetHostViewAndroid();
   gfx::Size physical_size(
       Java_ContentViewCore_getPhysicalBackingWidthPix(env, obj),
       Java_ContentViewCore_getPhysicalBackingHeightPix(env, obj));
   root_layer_->SetBounds(physical_size);
 
   if (view) {
     RenderWidgetHostImpl* host = RenderWidgetHostImpl::From(
         view->GetRenderWidgetHost());
     host->SendScreenRects();
     view->WasResized();
   }
 }
 
-long ContentViewCoreImpl::GetNativeImeAdapter(JNIEnv* env, jobject obj) {
+long ContentViewCoreImpl::GetNativeImeAdapter(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& obj) {
   RenderWidgetHostViewAndroid* rwhva = GetRenderWidgetHostViewAndroid();
   if (!rwhva)
     return 0;
   return rwhva->GetNativeImeAdapter();
 }
 
 void ContentViewCoreImpl::ForceUpdateImeAdapter(long native_ime_adapter) {
   JNIEnv* env = AttachCurrentThread();
   ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
   if (obj.is_null())
@@ skipping 25 matching lines @@
                                         text_input_flags,
                                         jstring_text.obj(),
                                         selection_start,
                                         selection_end,
                                         composition_start,
                                         composition_end,
                                         show_ime_if_needed,
                                         is_non_ime_change);
 }
 
-void ContentViewCoreImpl::SetAccessibilityEnabled(JNIEnv* env, jobject obj,
-                                                  bool enabled) {
+void ContentViewCoreImpl::SetAccessibilityEnabled(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& obj,
+    bool enabled) {
   SetAccessibilityEnabledInternal(enabled);
 }
 
-void ContentViewCoreImpl::SetTextTrackSettings(JNIEnv* env,
-                                               jobject obj,
-                                               jboolean textTracksEnabled,
-                                               jstring textTrackBackgroundColor,
-                                               jstring textTrackFontFamily,
-                                               jstring textTrackFontStyle,
-                                               jstring textTrackFontVariant,
-                                               jstring textTrackTextColor,
-                                               jstring textTrackTextShadow,
-                                               jstring textTrackTextSize) {
+void ContentViewCoreImpl::SetTextTrackSettings(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& obj,
+    jboolean textTracksEnabled,
+    const JavaParamRef<jstring>& textTrackBackgroundColor,
+    const JavaParamRef<jstring>& textTrackFontFamily,
+    const JavaParamRef<jstring>& textTrackFontStyle,
+    const JavaParamRef<jstring>& textTrackFontVariant,
+    const JavaParamRef<jstring>& textTrackTextColor,
+    const JavaParamRef<jstring>& textTrackTextShadow,
+    const JavaParamRef<jstring>& textTrackTextSize) {
   FrameMsg_TextTrackSettings_Params params;
   params.text_tracks_enabled = textTracksEnabled;
   params.text_track_background_color = ConvertJavaStringToUTF8(
       env, textTrackBackgroundColor);
   params.text_track_font_family = ConvertJavaStringToUTF8(
       env, textTrackFontFamily);
   params.text_track_font_style = ConvertJavaStringToUTF8(
       env, textTrackFontStyle);
   params.text_track_font_variant = ConvertJavaStringToUTF8(
       env, textTrackFontVariant);
@@ skipping 38 matching lines @@
 void ContentViewCoreImpl::SendOrientationChangeEventInternal() {
   RenderWidgetHostViewAndroid* rwhv = GetRenderWidgetHostViewAndroid();
   if (rwhv)
     rwhv->UpdateScreenInfo(GetViewAndroid());
 
   static_cast<WebContentsImpl*>(web_contents())->
       screen_orientation_dispatcher_host()->OnOrientationChange();
 }
 
 void ContentViewCoreImpl::ExtractSmartClipData(JNIEnv* env,
-                                               jobject obj,
+                                               const JavaParamRef<jobject>& obj,
                                                jint x,
                                                jint y,
                                                jint width,
                                                jint height) {
   gfx::Rect rect(
       static_cast<int>(x / dpi_scale()),
       static_cast<int>(y / dpi_scale()),
       static_cast<int>((width > 0 && width < dpi_scale()) ?
           1 : (int)(width / dpi_scale())),
       static_cast<int>((height > 0 && height < dpi_scale()) ?
           1 : (int)(height / dpi_scale())));
   GetWebContents()->Send(new ViewMsg_ExtractSmartClipData(
       GetWebContents()->GetRoutingID(), rect));
 }
 
-jint ContentViewCoreImpl::GetCurrentRenderProcessId(JNIEnv* env, jobject obj) {
+jint ContentViewCoreImpl::GetCurrentRenderProcessId(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& obj) {
   return GetRenderProcessIdFromRenderViewHost(
       web_contents_->GetRenderViewHost());
 }
 
-void ContentViewCoreImpl::SetBackgroundOpaque(JNIEnv* env, jobject jobj,
-    jboolean opaque) {
+void ContentViewCoreImpl::SetBackgroundOpaque(JNIEnv* env,
+                                              const JavaParamRef<jobject>& jobj,
+                                              jboolean opaque) {
   if (GetRenderWidgetHostViewAndroid()) {
     if (opaque)
       GetRenderWidgetHostViewAndroid()->SetBackgroundColorToDefault();
     else
       GetRenderWidgetHostViewAndroid()->SetBackgroundColor(SK_ColorTRANSPARENT);
   }
 }
 
 void ContentViewCoreImpl::RequestTextSurroundingSelection(
     int max_length,
@@ skipping 107 matching lines @@
     return ScopedJavaLocalRef<jobject>();
 
   return view->GetJavaObject();
 }
 
 bool RegisterContentViewCore(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace content