Fix inobject slack tracking for both subclassing and non-subclassing cases.

Fix inobject slack tracking for both subclassing and non-subclassing cases.

It didn't support subclassing case at all and in non-subclassing case the runtime
allocation didn't do the slack tracking step.

BUG=chromium:563339
LOG=Y

Committed: https://crrev.com/5d38d6819cb872e75b878864d285779959fd8e09
Cr-Commit-Position: refs/heads/master@{#32547}

[Igor Sheludko, 2015-12-01 14:32:54]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2015-12-01 14:35:44]

ishell@chromium.org changed reviewers:
+ verwaest@chromium.org

[Igor Sheludko, 2015-12-01 14:35:44]

PTAL. For now x64 only, other ports are on the way.

[Toon Verwaest, 2015-12-01 15:59:40]

What about doing slack tracking step in generated code after the allocation
worked? That way we don't need to have a second entrypoint.

[Igor Sheludko, 2015-12-02 11:42:46]

Patchset #2 (id:40001) has been deleted

[Igor Sheludko, 2015-12-02 11:46:12]

Patchset #2 (id:60001) has been deleted

[Igor Sheludko, 2015-12-02 12:02:35]

Patchset #2 (id:80001) has been deleted

[Igor Sheludko, 2015-12-02 12:04:37]

Now the slack tracking step is done after allocation.

[Igor Sheludko, 2015-12-02 14:21:38]

Patchset #2 (id:100001) has been deleted

[Igor Sheludko, 2015-12-02 15:58:12]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-02 15:58:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1488023002/110013
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1488023002/110013

[Igor Sheludko, 2015-12-02 15:58:19]

Patchset #3 (id:140001) has been deleted

[commit-bot: I haz the power, 2015-12-02 16:11:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-02 16:11:36]

Dry run: Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[Igor Sheludko, 2015-12-02 16:46:37]

Patchset #4 (id:170001) has been deleted

[Igor Sheludko, 2015-12-02 16:46:46]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-02 16:47:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1488023002/190001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1488023002/190001

[commit-bot: I haz the power, 2015-12-02 17:07:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-02 17:07:02]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2015-12-02 18:05:42]

lgtm

[Igor Sheludko, 2015-12-02 18:06:14]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2015-12-02 18:06:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1488023002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1488023002/200001

[Igor Sheludko, 2015-12-02 18:08:23]

ishell@chromium.org changed reviewers:
+ hpayer@chromium.org, mstarzinger@chromium.org

[Igor Sheludko, 2015-12-02 18:08:23]

Hannes, PTAL heap part.
Michi, PTAL Turbofan part.

[commit-bot: I haz the power, 2015-12-02 18:11:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-02 18:11:39]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8432)

[Michael Starzinger, 2015-12-02 18:41:57]

LGTM on "compiler".

https://codereview.chromium.org/1488023002/diff/200001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/1488023002/diff/200001/src/objects.h#newcode7265
src/objects.h:7265: // True if the initial_map is set and the object
constructions countdown
nit: This comment applied to the predicate, looks outdated, can we either adapt
or drop it?

[Hannes Payer (out of office), 2015-12-02 18:47:10]

heap lgtm

[Igor Sheludko, 2015-12-03 08:53:14]

Landing.

https://codereview.chromium.org/1488023002/diff/200001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/1488023002/diff/200001/src/objects.h#newcode7265
src/objects.h:7265: // True if the initial_map is set and the object
constructions countdown
On 2015/12/02 18:41:57, Michael Starzinger wrote:
> nit: This comment applied to the predicate, looks outdated, can we either
adapt
> or drop it?

Thanks! I updated and moved both this comment and the big comment about slack
tracking to Map.

[Igor Sheludko, 2015-12-03 08:53:48]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2015-12-03 08:53:49]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org,
verwaest@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1488023002/#ps220001
(title: "Moved and updated comments about slack tracking")

[commit-bot: I haz the power, 2015-12-03 08:53:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1488023002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1488023002/220001

[commit-bot: I haz the power, 2015-12-03 10:02:52]

Committed patchset #6 (id:220001)

[commit-bot: I haz the power, 2015-12-03 10:03:07]

Description was changed from

==========
Fix inobject slack tracking for both subclassing and non-subclassing cases.

It didn't support subclassing case at all and in non-subclassing case the
runtime
allocation didn't do the slack tracking step.

BUG=chromium:563339
LOG=Y
==========

to

==========
Fix inobject slack tracking for both subclassing and non-subclassing cases.

It didn't support subclassing case at all and in non-subclassing case the
runtime
allocation didn't do the slack tracking step.

BUG=chromium:563339
LOG=Y

Committed: https://crrev.com/5d38d6819cb872e75b878864d285779959fd8e09
Cr-Commit-Position: refs/heads/master@{#32547}
==========

[commit-bot: I haz the power, 2015-12-03 10:03:08]

Patchset 6 (id:??) landed as
https://crrev.com/5d38d6819cb872e75b878864d285779959fd8e09
Cr-Commit-Position: refs/heads/master@{#32547}