src/compiler/js-typed-lowering.cc - Issue 1488023002: Fix inobject slack tracking for both subclassing and non-subclassing cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-typed-lowering.cc

Issue 1488023002: Fix inobject slack tracking for both subclassing and non-subclassing cases. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Moved and updated comments about slack tracking Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/js-typed-lowering.cc

diff --git a/src/compiler/js-typed-lowering.cc b/src/compiler/js-typed-lowering.cc

index 8285e7e13daf852b55e61786d7710f55ca1a966f..f4e6306b600f1e03576dc48188eb5cd7db10baf6 100644

--- a/src/compiler/js-typed-lowering.cc

+++ b/src/compiler/js-typed-lowering.cc

@@ -1417,9 +1417,7 @@ Reduction JSTypedLowering::ReduceJSCreate(Node* node) {

DCHECK(constructor->IsConstructor());

// Force completion of inobject slack tracking before

// generating code to finalize the instance size.

- if (constructor->IsInobjectSlackTrackingInProgress()) {

- constructor->CompleteInobjectSlackTracking();

- }

+ constructor->CompleteInobjectSlackTrackingIfActive();

// TODO(bmeurer): We fall back to the runtime in case we cannot inline

// the allocation here, which is sort of expensive. We should think about

« no previous file with comments | « src/code-stubs.h ('k') | src/crankshaft/hydrogen.cc » ('j') | no next file with comments »