Fix inobject slack tracking for both subclassing and non-subclassing cases.

src/x64/builtins-x64.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if V8_TARGET_ARCH_X64
 
 #include "src/code-factory.h"
 #include "src/codegen.h"
 #include "src/deoptimizer.h"
 #include "src/full-codegen/full-codegen.h"
@@ skipping 153 matching lines @@
         // rdi: constructor
         // rax: initial map (if proven valid below)
         __ CmpObjectType(rax, MAP_TYPE, rbx);
         __ j(not_equal, &rt_call);
 
         // Fall back to runtime if the expected base constructor and base
         // constructor differ.
         __ cmpp(rdi, FieldOperand(rax, Map::kConstructorOrBackPointerOffset));
         __ j(not_equal, &rt_call);
 
-        if (!is_api_function) {
-          Label allocate;
-          // The code below relies on these assumptions.
-          STATIC_ASSERT(Map::Counter::kShift + Map::Counter::kSize == 32);
-          // Check if slack tracking is enabled.
-          __ movl(rsi, FieldOperand(rax, Map::kBitField3Offset));
-          __ shrl(rsi, Immediate(Map::Counter::kShift));
-          __ cmpl(rsi, Immediate(Map::kSlackTrackingCounterEnd));
-          __ j(less, &allocate);
-          // Decrease generous allocation count.
-          __ subl(FieldOperand(rax, Map::kBitField3Offset),
-                  Immediate(1 << Map::Counter::kShift));
-
-          __ cmpl(rsi, Immediate(Map::kSlackTrackingCounterEnd));
-          __ j(not_equal, &allocate);
-
-          // Push the constructor, new_target and map to the stack, and
-          // the map again as an argument to the runtime call.
-          __ Push(rax);
-          __ Push(rdx);
-          __ Push(rdi);
-
-          __ Push(rax);  // initial map
-          __ CallRuntime(Runtime::kFinalizeInstanceSize, 1);
-
-          __ Pop(rdi);
-          __ Pop(rdx);
-          __ Pop(rax);
-          __ movl(rsi, Immediate(Map::kSlackTrackingCounterEnd - 1));
-
-          __ bind(&allocate);
-        }
-
         // Now allocate the JSObject on the heap.
         __ movzxbp(r9, FieldOperand(rax, Map::kInstanceSizeOffset));
         __ shlp(r9, Immediate(kPointerSizeLog2));
         // r9: size of new object
         __ Allocate(r9, rbx, r9, no_reg, &rt_call, NO_ALLOCATION_FLAGS);
         // Allocated the JSObject, now initialize the fields.
         // rdi: constructor
         // rdx: new target
         // rax: initial map
         // rbx: JSObject (not HeapObject tagged - the actual address).
         // r9: start of next object
         __ movp(Operand(rbx, JSObject::kMapOffset), rax);
         __ LoadRoot(rcx, Heap::kEmptyFixedArrayRootIndex);
         __ movp(Operand(rbx, JSObject::kPropertiesOffset), rcx);
         __ movp(Operand(rbx, JSObject::kElementsOffset), rcx);
-        // Set extra fields in the newly allocated object.
-        // rax: initial map
-        // rdx: new target
-        // rbx: JSObject
-        // r9: start of next object
-        // rsi: slack tracking counter (non-API function case)
         __ leap(rcx, Operand(rbx, JSObject::kHeaderSize));
+
+        // Add the object tag to make the JSObject real, so that we can continue
+        // and jump into the continuation code at any time from now on.
+        __ orp(rbx, Immediate(kHeapObjectTag));
+
+        // Fill all the in-object properties with the appropriate filler.
+        // rbx: JSObject (tagged)
+        // rcx: First in-object property of JSObject (not tagged)
         __ LoadRoot(r11, Heap::kUndefinedValueRootIndex);
+
         if (!is_api_function) {
           Label no_inobject_slack_tracking;
 
+          // The code below relies on these assumptions.
+          STATIC_ASSERT(Map::Counter::kShift + Map::Counter::kSize == 32);
           // Check if slack tracking is enabled.
+          __ movl(rsi, FieldOperand(rax, Map::kBitField3Offset));
+          __ shrl(rsi, Immediate(Map::Counter::kShift));
           __ cmpl(rsi, Immediate(Map::kSlackTrackingCounterEnd));
           __ j(less, &no_inobject_slack_tracking);
+          __ Push(rsi);  // Save allocation count value.
+          // Decrease generous allocation count.
+          __ subl(FieldOperand(rax, Map::kBitField3Offset),
+                  Immediate(1 << Map::Counter::kShift));
 
           // Allocate object with a slack.
           __ movzxbp(rsi, FieldOperand(rax, Map::kUnusedPropertyFieldsOffset));
           __ negp(rsi);
           __ leap(rsi, Operand(r9, rsi, times_pointer_size, 0));
           // rsi: offset of first field after pre-allocated fields
           if (FLAG_debug_code) {
             __ cmpp(rcx, rsi);
             __ Assert(less_equal,
                       kUnexpectedNumberOfPreAllocatedPropertyFields);
           }
           __ InitializeFieldsWithFiller(rcx, rsi, r11);
 
           // To allow truncation fill the remaining fields with one pointer
           // filler map.
           __ LoadRoot(r11, Heap::kOnePointerFillerMapRootIndex);
+          __ InitializeFieldsWithFiller(rcx, r9, r11);
+
+          __ Pop(rsi);  // Restore allocation count value before decreasing.
+          __ cmpl(rsi, Immediate(Map::kSlackTrackingCounterEnd));
+          __ j(not_equal, &allocated);
+
+          // Push the constructor, new_target and the object to the stack,
+          // and then the initial map as an argument to the runtime call.
+          __ Push(rdi);
+          __ Push(rdx);
+          __ Push(rbx);
+
+          __ Push(rax);  // initial map
+          __ CallRuntime(Runtime::kFinalizeInstanceSize, 1);
+
+          __ Pop(rbx);
+          __ Pop(rdx);
+          __ Pop(rdi);
+
+          // Continue with JSObject being successfully allocated.
+          // rdi: constructor
+          // rdx: new target
+          // rbx: JSObject (tagged)
+          __ jmp(&allocated);
 
           __ bind(&no_inobject_slack_tracking);
         }
 
         __ InitializeFieldsWithFiller(rcx, r9, r11);
 
-        // Add the object tag to make the JSObject real, so that we can continue
-        // and jump into the continuation code at any time from now on.
-        // rbx: JSObject (untagged)
-        __ orp(rbx, Immediate(kHeapObjectTag));
-
         // Continue with JSObject being successfully allocated
         // rdi: constructor
         // rdx: new target
         // rbx: JSObject (tagged)
         __ jmp(&allocated);
       }
 
       // Allocate the new receiver object using the runtime call.
       // rdi: constructor
       // rdx: new target
@@ skipping 1788 matching lines @@
   __ ret(0);
 }
 
 
 #undef __
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_TARGET_ARCH_X64