src/factory.cc - Issue 1488023002: Fix inobject slack tracking for both subclassing and non-subclassing cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 1488023002: Fix inobject slack tracking for both subclassing and non-subclassing cases. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Moved and updated comments about slack tracking Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index 38e1f94ab0fcf108c1c73c35963675bc505ccb0f..37ce2f0cc030793136259aff2a546cfc7b8fe0a1 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -1653,7 +1653,7 @@ Handle<JSGeneratorObject> Factory::NewJSGeneratorObject(

DCHECK(function->shared()->is_generator());

JSFunction::EnsureHasInitialMap(function);

Handle<Map> map(function->initial_map());

- DCHECK(map->instance_type() == JS_GENERATOR_OBJECT_TYPE);

+ DCHECK_EQ(JS_GENERATOR_OBJECT_TYPE, map->instance_type());

CALL_HEAP_FUNCTION(

isolate(),

isolate()->heap()->AllocateJSObjectFromMap(*map),

« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/heap/heap.cc » ('j') | no next file with comments »