Add more components to "gn check", work on dom_distiller.

Add more components to "gn check", work on dom_distiller.

Added components are:
  bitmap_uploader
  browser_sync
  dom_distiller
  exp
  proxy_config
  query_parser
  rappor
  renderer_context_menu
  resource_provider
  resources
  rlz
  safe_browsing_db
  safe_json
  scheduler
  search

The dom distiller GN build was a little messed up. The JNI registrar files were in core but referenced files in content. I moved the registrar files to content/browser which is where they're needed and matches some other components. There were also some other duplicated java targets, and I split out the content build file into separate subdirectories and renamed the targets to match.

TBR=dpranke@chromium.org
BUG=562773
Committed: https://crrev.com/15764b1f1b8fe2d0ba0328235d55516ac3415276
Cr-Commit-Position: refs/heads/master@{#362234}

[brettw, 2015-11-28 04:48:46]

Description was changed from

==========
Add more components, device to "gn check"
==========

to

==========
Add more components, device to "gn check".

Added components are:
  components:*
  bitmap_uploader
  browser_sync
  dom_distiller
  exp
  proxy_config
  query_parser
  rappor
  renderer_context_menu
  resource_provider
  resources
  rlz
  safe_browsing_db
  safe_json
  scheduler
  search

TBR=dpranke@chromium.org
==========

[brettw, 2015-11-28 04:48:46]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2015-11-28 04:49:11]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-11-28 04:49:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1487433002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1487433002/20001

[commit-bot: I haz the power, 2015-11-28 04:53:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-28 04:53:02]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-11-28 05:29:56]

Description was changed from

==========
Add more components, device to "gn check".

Added components are:
  components:*
  bitmap_uploader
  browser_sync
  dom_distiller
  exp
  proxy_config
  query_parser
  rappor
  renderer_context_menu
  resource_provider
  resources
  rlz
  safe_browsing_db
  safe_json
  scheduler
  search

TBR=dpranke@chromium.org
==========

to

==========
Add more components, device to "gn check".

Added components are:
  components:*
  bitmap_uploader
  browser_sync
  dom_distiller
  exp
  proxy_config
  query_parser
  rappor
  renderer_context_menu
  resource_provider
  resources
  rlz
  safe_browsing_db
  safe_json
  scheduler
  search

TBR=dpranke@chromium.org
BUG=562773
==========

[brettw, 2015-11-28 05:30:00]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-11-28 05:30:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1487433002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1487433002/40001

[commit-bot: I haz the power, 2015-11-28 05:34:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-28 05:34:10]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[brettw, 2015-11-28 05:41:29]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-11-28 05:41:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1487433002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1487433002/60001

[commit-bot: I haz the power, 2015-11-28 05:44:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-28 05:44:31]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-11-28 06:05:26]

Description was changed from

==========
Add more components, device to "gn check".

Added components are:
  components:*
  bitmap_uploader
  browser_sync
  dom_distiller
  exp
  proxy_config
  query_parser
  rappor
  renderer_context_menu
  resource_provider
  resources
  rlz
  safe_browsing_db
  safe_json
  scheduler
  search

TBR=dpranke@chromium.org
BUG=562773
==========

to

==========
Add more components to "gn check".

Added components are:
  components:*
  bitmap_uploader
  browser_sync
  dom_distiller
  exp
  proxy_config
  query_parser
  rappor
  renderer_context_menu
  resource_provider
  resources
  rlz
  safe_browsing_db
  safe_json
  scheduler
  search

TBR=dpranke@chromium.org
BUG=562773
==========

[brettw, 2015-11-28 06:05:42]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-11-28 06:05:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1487433002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1487433002/80001

[commit-bot: I haz the power, 2015-11-28 06:11:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-28 06:11:20]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-11-28 06:23:05]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-11-28 06:23:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1487433002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1487433002/100001

[commit-bot: I haz the power, 2015-11-28 06:28:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-28 06:28:24]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[brettw, 2015-11-28 06:57:43]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-11-28 06:57:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1487433002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1487433002/120001

[commit-bot: I haz the power, 2015-11-28 07:02:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-28 07:02:55]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[brettw, 2015-11-28 07:18:57]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-11-28 07:19:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1487433002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1487433002/140001

[commit-bot: I haz the power, 2015-11-28 07:24:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-28 07:24:30]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[brettw, 2015-11-28 16:23:56]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-11-28 16:24:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1487433002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1487433002/160001

[commit-bot: I haz the power, 2015-11-28 16:28:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-28 16:28:58]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[brettw, 2015-11-28 17:44:54]

fix

[brettw, 2015-11-28 17:44:55]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-11-28 17:45:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1487433002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1487433002/180001

[commit-bot: I haz the power, 2015-11-28 17:49:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-28 17:49:33]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[brettw, 2015-11-28 17:58:04]

fix

[brettw, 2015-11-28 17:58:05]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-11-28 17:58:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1487433002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1487433002/200001

[commit-bot: I haz the power, 2015-11-28 18:05:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-28 18:05:07]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[brettw, 2015-11-29 16:18:01]

Description was changed from

==========
Add more components to "gn check".

Added components are:
  components:*
  bitmap_uploader
  browser_sync
  dom_distiller
  exp
  proxy_config
  query_parser
  rappor
  renderer_context_menu
  resource_provider
  resources
  rlz
  safe_browsing_db
  safe_json
  scheduler
  search

TBR=dpranke@chromium.org
BUG=562773
==========

to

==========
Add more components to "gn check".

Added components are:
  bitmap_uploader
  browser_sync
  dom_distiller
  exp
  proxy_config
  query_parser
  rappor
  renderer_context_menu
  resource_provider
  resources
  rlz
  safe_browsing_db
  safe_json
  scheduler
  search

TBR=dpranke@chromium.org
BUG=562773
==========

[brettw, 2015-11-29 16:18:45]

removed

[brettw, 2015-11-29 16:18:46]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-11-29 16:19:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1487433002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1487433002/220001

[commit-bot: I haz the power, 2015-11-29 16:41:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-29 16:41:20]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[brettw, 2015-11-29 17:11:44]

Description was changed from

==========
Add more components to "gn check".

Added components are:
  bitmap_uploader
  browser_sync
  dom_distiller
  exp
  proxy_config
  query_parser
  rappor
  renderer_context_menu
  resource_provider
  resources
  rlz
  safe_browsing_db
  safe_json
  scheduler
  search

TBR=dpranke@chromium.org
BUG=562773
==========

to

==========
Add more components to "gn check", work on dom_distiller.

Added components are:
  bitmap_uploader
  browser_sync
  dom_distiller
  exp
  proxy_config
  query_parser
  rappor
  renderer_context_menu
  resource_provider
  resources
  rlz
  safe_browsing_db
  safe_json
  scheduler
  search

The dom distiller GN build was a little messed up. The JNI registrar files were
in core but referenced files in content. I moved the registrar files to
content/browser which is where they're needed and matches some other components.
There were also some other duplicated java targets, and I split out the content
build file into separate subdirectories and renamed the targets to match.

TBR=dpranke@chromium.org
BUG=562773
==========

[brettw, 2015-11-29 17:13:55]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2015-11-29 17:13:59]

dom_distiller

[commit-bot: I haz the power, 2015-11-29 17:14:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1487433002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1487433002/240001

[commit-bot: I haz the power, 2015-11-29 17:19:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-29 17:19:04]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[brettw, 2015-11-29 17:24:34]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2015-11-29 17:24:38]

dom_distiller

[commit-bot: I haz the power, 2015-11-29 17:24:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1487433002/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1487433002/260001

[commit-bot: I haz the power, 2015-11-29 17:29:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-29 17:29:36]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[brettw, 2015-11-29 17:40:52]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2015-11-29 17:40:53]

dom_distiller

[commit-bot: I haz the power, 2015-11-29 17:41:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1487433002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1487433002/280001

[commit-bot: I haz the power, 2015-11-29 18:01:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-29 18:01:15]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[brettw, 2015-11-29 18:19:12]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2015-11-29 18:19:13]

dom_distiller

[commit-bot: I haz the power, 2015-11-29 18:19:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1487433002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1487433002/300001

[Dirk Pranke, 2015-11-29 18:25:41]

https://codereview.chromium.org/1487433002/diff/280001/components/BUILD.gn
File components/BUILD.gn (left):

https://codereview.chromium.org/1487433002/diff/280001/components/BUILD.gn#ol...
components/BUILD.gn:473: if (!is_android) {
doesn't moving these out cause them to get pulled in on iOS?

https://codereview.chromium.org/1487433002/diff/280001/components/BUILD.gn
File components/BUILD.gn (right):

https://codereview.chromium.org/1487433002/diff/280001/components/BUILD.gn#ne...
components/BUILD.gn:514: } else {  # !is_android
maybe this should be else if (!is_ios) ?

https://codereview.chromium.org/1487433002/diff/280001/components/BUILD.gn#ne...
components/BUILD.gn:642: if (is_android || is_linux || is_mac || is_win) {
is this just (!is_ios) ? maybe merge with the block on line 654? I'm not sure if
we care about is_nacl or not here ...

https://codereview.chromium.org/1487433002/diff/280001/components/proxy_confi...
File components/proxy_config/BUILD.gn (right):

https://codereview.chromium.org/1487433002/diff/280001/components/proxy_confi...
components/proxy_config/BUILD.gn:32: # TODO bug 562773: Break a header include
cycle on ChromeOS and disable
Nit: TODO(crbug.com/562773)

[commit-bot: I haz the power, 2015-11-29 19:26:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-29 19:26:51]

Dry run: This issue passed the CQ dry run.

[brettw, 2015-11-30 18:48:03]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2015-11-30 18:48:05]

Review comments

[brettw, 2015-11-30 18:48:31]

New snap up.

https://codereview.chromium.org/1487433002/diff/280001/components/BUILD.gn
File components/BUILD.gn (left):

https://codereview.chromium.org/1487433002/diff/280001/components/BUILD.gn#ol...
components/BUILD.gn:473: if (!is_android) {
On 2015/11/29 18:25:41, Dirk Pranke wrote:
> doesn't moving these out cause them to get pulled in on iOS?

Done.

https://codereview.chromium.org/1487433002/diff/280001/components/BUILD.gn
File components/BUILD.gn (right):

https://codereview.chromium.org/1487433002/diff/280001/components/BUILD.gn#ne...
components/BUILD.gn:514: } else {  # !is_android
On 2015/11/29 18:25:41, Dirk Pranke wrote:
> maybe this should be else if (!is_ios) ?

I just added a separate block for !android and !ios and labeled it "desktop"
since I think this it's easier to reason about this way.

https://codereview.chromium.org/1487433002/diff/280001/components/BUILD.gn#ne...
components/BUILD.gn:642: if (is_android || is_linux || is_mac || is_win) {
I just added it to the !ios block below.

[commit-bot: I haz the power, 2015-11-30 18:50:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1487433002/320001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1487433002/320001

[brettw, 2015-11-30 20:09:27]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2015-11-30 20:09:30]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-11-30 20:12:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1487433002/320001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1487433002/320001

[commit-bot: I haz the power, 2015-11-30 22:11:11]

Description was changed from

==========
Add more components to "gn check", work on dom_distiller.

Added components are:
  bitmap_uploader
  browser_sync
  dom_distiller
  exp
  proxy_config
  query_parser
  rappor
  renderer_context_menu
  resource_provider
  resources
  rlz
  safe_browsing_db
  safe_json
  scheduler
  search

The dom distiller GN build was a little messed up. The JNI registrar files were
in core but referenced files in content. I moved the registrar files to
content/browser which is where they're needed and matches some other components.
There were also some other duplicated java targets, and I split out the content
build file into separate subdirectories and renamed the targets to match.

TBR=dpranke@chromium.org
BUG=562773
==========

to

==========
Add more components to "gn check", work on dom_distiller.

Added components are:
  bitmap_uploader
  browser_sync
  dom_distiller
  exp
  proxy_config
  query_parser
  rappor
  renderer_context_menu
  resource_provider
  resources
  rlz
  safe_browsing_db
  safe_json
  scheduler
  search

The dom distiller GN build was a little messed up. The JNI registrar files were
in core but referenced files in content. I moved the registrar files to
content/browser which is where they're needed and matches some other components.
There were also some other duplicated java targets, and I split out the content
build file into separate subdirectories and renamed the targets to match.

TBR=dpranke@chromium.org
BUG=562773
==========

[commit-bot: I haz the power, 2015-11-30 22:11:13]

Committed patchset #17 (id:320001)

[commit-bot: I haz the power, 2015-11-30 22:12:09]

Description was changed from

==========
Add more components to "gn check", work on dom_distiller.

Added components are:
  bitmap_uploader
  browser_sync
  dom_distiller
  exp
  proxy_config
  query_parser
  rappor
  renderer_context_menu
  resource_provider
  resources
  rlz
  safe_browsing_db
  safe_json
  scheduler
  search

The dom distiller GN build was a little messed up. The JNI registrar files were
in core but referenced files in content. I moved the registrar files to
content/browser which is where they're needed and matches some other components.
There were also some other duplicated java targets, and I split out the content
build file into separate subdirectories and renamed the targets to match.

TBR=dpranke@chromium.org
BUG=562773
==========

to

==========
Add more components to "gn check", work on dom_distiller.

Added components are:
  bitmap_uploader
  browser_sync
  dom_distiller
  exp
  proxy_config
  query_parser
  rappor
  renderer_context_menu
  resource_provider
  resources
  rlz
  safe_browsing_db
  safe_json
  scheduler
  search

The dom distiller GN build was a little messed up. The JNI registrar files were
in core but referenced files in content. I moved the registrar files to
content/browser which is where they're needed and matches some other components.
There were also some other duplicated java targets, and I split out the content
build file into separate subdirectories and renamed the targets to match.

TBR=dpranke@chromium.org
BUG=562773

Committed: https://crrev.com/15764b1f1b8fe2d0ba0328235d55516ac3415276
Cr-Commit-Position: refs/heads/master@{#362234}
==========

[commit-bot: I haz the power, 2015-11-30 22:12:10]

Patchset 17 (id:??) landed as
https://crrev.com/15764b1f1b8fe2d0ba0328235d55516ac3415276
Cr-Commit-Position: refs/heads/master@{#362234}

[Dirk Pranke, 2015-12-01 02:11:42]

lgtm, though we should be on the lookout for a possible ios breakage as noted
below (of course, the bots aren't live yet).

https://codereview.chromium.org/1487433002/diff/320001/components/BUILD.gn
File components/BUILD.gn (right):

https://codereview.chromium.org/1487433002/diff/320001/components/BUILD.gn#ne...
components/BUILD.gn:531: deps += [ "//components/rlz:unit_tests" ]
I think this'll now get pulled in on iOS (where enable_rlz_support is also true)
where it wasn't before,
but that's probably (?) okay. If not, we can fix it later.