Add more components to "gn check", work on dom_distiller.

components/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//testing/test.gni")
 import("//tools/grit/repack.gni")
 
 if (is_android) {
@@ skipping 338 matching lines @@
 
   deps = [
     "//base",
     "//base/test:test_support",
     "//components/autofill/core/browser:unit_tests",
     "//components/autofill/core/common:unit_tests",
     "//components/bookmarks/browser:unit_tests",
     "//components/bookmarks/managed:unit_tests",
     "//components/compression:unit_tests",
     "//components/content_settings/core/browser:unit_tests",
+    "//components/content_settings/core/common",
     "//components/content_settings/core/common:unit_tests",
     "//components/data_usage/core:unit_tests",
     "//components/dom_distiller/core:unit_tests",
     "//components/enhanced_bookmarks:unit_tests",
     "//components/favicon/core:unit_tests",
     "//components/favicon_base:unit_tests",
     "//components/flags_ui:unit_tests",
     "//components/gcm_driver:unit_tests",
     "//components/google/core/browser:unit_tests",
     "//components/history/core/browser:unit_tests",
@@ skipping 22 matching lines @@
     "//components/translate/core/browser:unit_tests",
     "//components/translate/core/common:unit_tests",
     "//components/translate/core/language_detection:unit_tests",
     "//components/undo:unit_tests",
     "//components/update_client:unit_tests",
     "//components/upload_list:unit_tests",
     "//components/variations:unit_tests",
     "//components/variations/service:unit_tests",
     "//components/web_resource:unit_tests",
     "//net",
+    "//testing/gtest",
     "//ui/base",
+    "//ui/gl:test_support",
     "//ui/resources:ui_test_pak",
   ]
 
-  if (!is_ios) {
+  if (is_ios) {
+    deps += [
+      "//components/signin/ios/browser:unit_tests",
+      "//components/translate/ios/browser:unit_tests",
+      "//components/webp_transcode:unit_tests",
+    ]
+  } else {  # !iOS
     deps += [
       "//components/auto_login_parser:unit_tests",
       "//components/autofill/content/browser:unit_tests",
       "//components/autofill/content/renderer:unit_tests",
       "//components/bubble:unit_tests",
       "//components/captive_portal:unit_tests",
       "//components/certificate_transparency:unit_tests",
       "//components/cloud_devices/common:unit_tests",
       "//components/component_updater:unit_tests",
       "//components/crx_file:unit_tests",
       "//components/data_reduction_proxy/content/browser:unit_tests",
       "//components/data_reduction_proxy/core/browser:unit_tests",
       "//components/data_reduction_proxy/core/common:unit_tests",
       "//components/data_use_measurement/content:unit_tests",
       "//components/device_event_log:unit_tests",
       "//components/devtools_http_handler:unit_tests",
-      "//components/dom_distiller/content:unit_tests",
+      "//components/dom_distiller/content/browser:unit_tests",
       "//components/domain_reliability:unit_tests",
       "//components/error_page/renderer:unit_tests",
       "//components/favicon/content:unit_tests",
       "//components/gcm_driver/crypto:unit_tests",
-      "//components/gcm_driver/instance_id:unit_tests",
       "//components/guest_view/browser:unit_tests",
       "//components/history/content/browser:unit_tests",
       "//components/json_schema:unit_tests",
       "//components/keyed_service/content:unit_tests",
       "//components/language_usage_metrics:unit_tests",
       "//components/login:unit_tests",
       "//components/memory_pressure:unit_tests",
       "//components/mime_util:unit_tests",
       "//components/navigation_interception:unit_tests",
       "//components/network_hints/renderer:unit_tests",
@@ skipping 25 matching lines @@
       "//components/wallpaper:unit_tests",
       "//components/web_cache/browser:unit_tests",
       "//components/webcrypto:unit_tests",
       "//components/webdata/common:unit_tests",
 
       # These are the deps required by the code in this target.
       "//components/policy:policy_component",
       "//content/test:test_support",
     ]
 
-    if (!is_android) {

[Dirk Pranke, 2015/11/29 18:25:41]

doesn't moving these out cause them to get pulled in on iOS?

[brettw, 2015/11/30 18:48:31]

Done.

-      deps += [
-        "//components/audio_modem:unit_tests",
-        "//components/copresence:unit_tests",
-        "//components/feedback:unit_tests",
-        "//components/proximity_auth:unit_tests",
-        "//components/storage_monitor:unit_tests",
-        "//components/web_modal:unit_tests",
-        "//components/webusb:unit_tests",
-      ]
-    }
     data_deps = [
       ":components_tests_pak",
       "//third_party/mesa:osmesa",
       "//ui/resources:ui_test_pak",
     ]
+  }  # iOS/!iOS
 
-    if (enable_rlz_support) {
-      deps += [ "//components/rlz:unit_tests" ]
-    }
-    if (is_android) {
-      isolate_file = "components_unittests.isolate"
+  if (is_android) {
+    isolate_file = "components_unittests.isolate"
 
-      deps += [ "//content/public/android:content_java" ]
-      deps -= [ "//components/gcm_driver/instance_id:unit_tests" ]
+    deps += [
+      "//components/invalidation/impl",
+      "//components/safe_json",
+      "//components/signin/core/browser",
+      "//content/public/android:content_java",
+      "//content/public/browser",
+      "//net",
+      "//ui/base",
+      "//ui/gfx",
+    ]
 
-      apk_deps = [
-        "//components/invalidation/impl:java",
-        "//components/safe_json/android:safe_json_java",
-        "//components/signin/core/browser/android:java",
-        "//components/variations/android:variations_java",
-        "//content/public/android:content_java",
-        "//ui/android:ui_java",
-      ]
-
-      if (enable_configuration_policy) {
-        apk_deps += [ "//components/policy/android:policy_java" ]
-      }
-    }
-    if (is_chromeos) {
-      deps += [
-        "//components/arc:unit_tests",
-        "//components/ownership:unit_tests",
-      ]
-    }
-
-    # TODO(GYP) need this target.
-    #'breakpad/app/crash_keys_win_unittest.cc',
+    apk_deps = [
+      "//components/invalidation/impl:java",
+      "//components/safe_json/android:safe_json_java",
+      "//components/signin/core/browser/android:java",
+      "//components/variations/android:variations_java",
+      "//content/public/android:content_java",
+      "//ui/android:ui_java",
+    ]
 
     if (enable_configuration_policy) {
-      deps += [
-        "//components/policy/core/browser:unit_tests",
-        "//components/policy/core/common:unit_tests",
-      ]
+      apk_deps += [ "//components/policy/android:policy_java" ]
     }
-  } else {
+  } else {  # !is_android

[Dirk Pranke, 2015/11/29 18:25:41]

maybe this should be else if (!is_ios) ?

[brettw, 2015/11/30 18:48:31]

I just added a separate block for !android and !ios and labeled it "desktop"
since I think this it's easier to reason about this way.

     deps += [
-      "//components/signin/ios/browser:unit_tests",
-      "//components/translate/ios/browser:unit_tests",
-      "//components/webp_transcode:unit_tests",
+      "//components/audio_modem:unit_tests",
+      "//components/copresence:unit_tests",
+      "//components/feedback:unit_tests",
+      "//components/gcm_driver/instance_id:unit_tests",
+      "//components/proximity_auth:unit_tests",
+      "//components/storage_monitor:unit_tests",
+      "//components/web_modal:unit_tests",
+      "//components/webusb:unit_tests",
     ]
   }
 
+  if (enable_rlz_support) {
+    deps += [ "//components/rlz:unit_tests" ]
+  }
+  if (is_chromeos) {
+    deps += [
+      "//components/arc:unit_tests",
+      "//components/ownership:unit_tests",
+    ]
+  }
+
+  # TODO(GYP) need this target.
+  #'breakpad/app/crash_keys_win_unittest.cc',
+
+  if (enable_configuration_policy) {
+    deps += [
+      "//components/policy/core/browser:unit_tests",
+      "//components/policy/core/common:unit_tests",
+    ]
+  }
+
   if (toolkit_views) {
     # TODO bug 522654 Enable this when the undefined symbol is fixed in
     # web_modal such that this links.
     #deps += [ "//components/constrained_window:unit_tests" ]
   }
 
   if (is_win) {
     deps += [ "//components/browser_watcher:unit_tests" ]
   }
 
@@ skipping 65 matching lines @@
 # The _run targets exist only for compatibility w/ GYP.
 group("components_browsertests_run") {
   testonly = true
   deps = [
     ":components_browsertests",
   ]
 }
 
 test("components_browsertests") {
   sources = []
+  defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ]
+  data = []
+  deps = [
+    "//base",
+    "//base/test:test_support",
+    "//components/strings",
+    "//testing/gmock",
+    "//testing/gtest",
+  ]
+
+  if (is_android || is_linux || is_mac || is_win) {

[Dirk Pranke, 2015/11/29 18:25:41]

is this just (!is_ios) ? maybe merge with the block on line 654? I'm not sure if
we care about is_nacl or not here ...

[brettw, 2015/11/30 18:48:31]

I just added it to the !ios block below.

+    data += [
+      "test/data/",
+      "dom_distiller/core/javascript/",
+      "//third_party/dom_distiller_js/dist/test/data/",
+    ]
+  }
+
+  if (is_mac) {
+    data += [ "$root_out_dir/Content Shell.app/" ]
+  }
+
   if (!is_ios) {
     sources = [
       "autofill/content/browser/risk/fingerprint_browsertest.cc",
       "autofill/content/renderer/password_form_conversion_utils_browsertest.cc",
       "dom_distiller/content/browser/distillable_page_utils_browsertest.cc",
       "dom_distiller/content/browser/distiller_page_web_contents_browsertest.cc",
       "dom_distiller/content/browser/test/dom_distiller_js_browsertest.cc",
       "password_manager/content/renderer/credential_manager_client_browsertest.cc",
       "tracing/child_trace_message_filter_browsertest.cc",
     ]
 
-    data = [
+    data += [
       "$root_out_dir/components_tests_resources.pak",
       "$root_out_dir/content_shell.pak",
     ]
-  }
-  if (is_android || is_linux || is_mac || is_win) {
-    data += [
-      "test/data/",
-      "dom_distiller/core/javascript/",
-      "//third_party/dom_distiller_js/dist/test/data/",
-    ]
-  }
 
-  if (is_mac) {
-    data += [ "$root_out_dir/Content Shell.app/" ]
-  }
-
-  defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ]
-  deps = [
-    "//base",
-    "//base/test:test_support",
-    "//components/strings",
-    "//testing/gmock",
-    "//testing/gtest",
-  ]
-  if (!is_ios) {
     deps += [
       "//components/autofill/content/browser",
       "//components/autofill/content/renderer",
+      "//components/autofill/core/browser",
       "//components/content_settings/core/common",
-      "//components/dom_distiller/content:content_browser",
+      "//components/dom_distiller/content/browser",
       "//components/dom_distiller/core",
       "//components/dom_distiller/core:test_support",
       "//components/password_manager/content/browser",
       "//components/password_manager/content/common",
       "//components/password_manager/content/renderer",
       "//components/tracing",
+      "//content/shell:content_shell_lib",
       "//content/test:browsertest_support",
       "//content/test:test_support",
       "//device/bluetooth",
+      "//ipc:test_support",
+      "//net:test_support",
       "//ui/base",
     ]
 
     data_deps = [
       ":components_tests_pak",
       "//third_party/mesa:osmesa",
     ]
   }
   if (is_android) {
     sources += [ "test/android/browsertests_apk/components_browser_tests_jni_onload.cc" ]
     sources -= [ "autofill/content/browser/risk/fingerprint_browsertest.cc" ]
-    deps += [ "//testing/android/native_test:native_test_support" ]
+    deps += [
+      "//content/test:layouttest_support",
+      "//testing/android/native_test:native_test_support",
+    ]
     use_default_launcher = false
     isolate_file = "components_browsertests.isolate"
     android_manifest =
         "${target_gen_dir}/components_browsertests_manifest/AndroidManifest.xml"
     apk_deps = [
       ":components_browsertests_assets",
       ":components_browsertests_java",
       ":components_browsertests_manifest",
     ]
   }
 
   if (is_linux) {
     # content_extractor_browsertest is a standalone content extraction tool built as
     # a MANUAL component_browsertest.
     sources += [ "dom_distiller/standalone/content_extractor_browsertest.cc" ]
     deps += [
       "//base:prefs_test_support",
+      "//components/leveldb_proto",
       "//components/pref_registry:test_support",
     ]
   }
 
   if (enable_basic_printing || enable_print_preview) {
     sources += [ "printing/test/print_web_view_helper_browsertest.cc" ]
     deps += [ "//components/printing/test:test_support" ]
   }
 }
 
 test("components_perftests") {
   sources = [
     "scheduler/base/task_queue_manager_delegate_for_test.cc",
     "scheduler/base/task_queue_manager_delegate_for_test.h",
     "scheduler/base/task_queue_manager_perftest.cc",
     "visitedlink/test/visitedlink_perftest.cc",
   ]
 
   # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
   configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
 
   deps = [
+    "//base/test:test_support",
     "//testing/gtest",
     "//testing/perf",
   ]
   if (!is_ios) {
     deps += [
       "//base",
       "//base/test:test_support_perf",
+      "//components/scheduler",
       "//components/visitedlink/browser",
       "//content/test:test_support",
     ]
   }
 }