Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3036)

Unified Diff: components/proxy_config/BUILD.gn

Issue 1487433002: Add more components to "gn check", work on dom_distiller. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/proxy_config/BUILD.gn
diff --git a/components/proxy_config/BUILD.gn b/components/proxy_config/BUILD.gn
index d122766cb60fedfa4e19af65efdd1c67be5cd96c..6430d948311838c0d5a38226b97982bfbe4e8b86 100644
--- a/components/proxy_config/BUILD.gn
+++ b/components/proxy_config/BUILD.gn
@@ -28,6 +28,16 @@ component("proxy_config") {
"//net",
"//url",
]
+
+ # TODO(https://crbug.com/562773): Break a header include cycle on ChromeOS
+ # and disable include checking so GN doesn't complain about the missing
+ # dependency (it still links OK). This cycle should be fixed and header
+ # checking enabled.
+ if (is_chromeos) {
+ check_includes = false
+ } else {
+ deps += [ "//components/pref_registry" ]
+ }
}
source_set("unit_tests") {
@@ -39,6 +49,10 @@ source_set("unit_tests") {
]
deps = [
":proxy_config",
+ "//base",
+ "//base:prefs_test_support",
+ "//base/test:test_support",
+ "//net",
"//testing/gmock",
"//testing/gtest",
]

Powered by Google App Engine
This is Rietveld 408576698