Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: .gn

Issue 1487433002: Add more components to "gn check", work on dom_distiller. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | components/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: .gn
diff --git a/.gn b/.gn
index 13d453715f349ffff38c6e43da44d3a58def9f6c..75faf76d7aa79b5ede11b936dea479fd48111d9c 100644
--- a/.gn
+++ b/.gn
@@ -34,14 +34,17 @@ check_targets = [
#"//chrome_elf/*",
#"//cloud_print/*",
- #"//components/*", # Lots of errors.
+ #"//components/*", # Needs nacl below.
+ #"//components:*", # Some Android unit tests.
"//components/about_handler/*",
"//components/about_ui/*",
"//components/app_modal/*",
"//components/audio_modem/*",
"//components/autofill/*",
"//components/auto_login_parser/*",
+ "//components/bitmap_uploader/*",
"//components/bookmarks/*",
+ "//components/browser_sync/*",
"//components/browser_watcher/*",
"//components/browsing_data/*",
"//components/bubble/*",
@@ -68,15 +71,12 @@ check_targets = [
"//components/devtools_discovery/*",
"//components/devtools_http_handler/*",
"//components/devtools_service/*",
-
- # There are some Android problems where the jni_registrar referenced from
- # core includes stuff from the content version of the dom_distiller.
- #"//components/dom_distiller/*",
-
+ "//components/dom_distiller/*",
"//components/domain_reliability/*",
"//components/drive/*",
"//components/enhanced_bookmarks/*",
"//components/error_page/*",
+ "//components/exp/*",
"//components/external_video_surface/*",
"//components/favicon/*",
"//components/favicon_base/*",
@@ -130,18 +130,17 @@ check_targets = [
"//components/pref_registry/*",
"//components/printing/*",
"//components/proximity_auth/*",
-
- #"//components/proxy_config/*",
- #"//components/query_parser/*",
- #"//components/rappor/*",
- #"//components/renderer_context_menu/*",
- #"//components/resource_provider/*",
- #"//components/resources/*",
- #"//components/rlz/*",
-
- #"//components/safe_json/*",
- #"//components/scheduler/*",
- #"//components/search/*",
+ "//components/proxy_config/*",
+ "//components/query_parser/*",
+ "//components/rappor/*",
+ "//components/renderer_context_menu/*",
+ "//components/resource_provider/*",
+ "//components/resources/*",
+ "//components/rlz/*",
+ "//components/safe_browsing_db/*",
+ "//components/safe_json/*",
+ "//components/scheduler/*",
+ "//components/search/*",
"//components/search_engines/*",
"//components/search_provider_logos/*",
"//components/security_interstitials/*",
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | components/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698