Metrics for user interests shown on the NTP.

Metrics for user interests shown on the NTP.

Histograms:
NewTabPage.Interests.ImageDownloadSuccess
NewTabPage.Interests.InterestsFetchSuccess
NewTabPage.Interests.NumInterests

UserActions:
MobileNTP.Interests.Click
MobileNTP.Interests.Dismissed

Also updated the NewTabPage.ActionAndroid histogram for snippets and interests clicks.

Depends on https://codereview.chromium.org/1459593002/

Saving some intrusive changes till the dependent code is submitted.

BUG=537145, 521030
Committed: https://crrev.com/8430ab46caf6988e34d8a6503822eb4e71f90e04
Cr-Commit-Position: refs/heads/master@{#365769}

[knn, 2015-12-02 14:58:56]

Description was changed from

==========
Metrics for user interests shown on the NTP.

BUG=537145,521030
==========

to

==========
Metrics for user interests shown on the NTP.

Histograms:
NewTabPage.Interests.ImageDownloadSuccess
NewTabPage.Interests.InterestsFetchSuccess
NewTabPage.Interests.NumInterests

UserActions:
MobileNTP.Interests.Opened
MobileNTP.Interests.Click
MobileNTP.Interests.Dismissed

Depends on https://codereview.chromium.org/1459593002/

Saving some intrusive changes till the dependent code is submitted.

BUG=537145,521030
==========

[knn, 2015-12-09 07:24:41]

Description was changed from

==========
Metrics for user interests shown on the NTP.

Histograms:
NewTabPage.Interests.ImageDownloadSuccess
NewTabPage.Interests.InterestsFetchSuccess
NewTabPage.Interests.NumInterests

UserActions:
MobileNTP.Interests.Opened
MobileNTP.Interests.Click
MobileNTP.Interests.Dismissed

Depends on https://codereview.chromium.org/1459593002/

Saving some intrusive changes till the dependent code is submitted.

BUG=537145,521030
==========

to

==========
Metrics for user interests shown on the NTP.

Histograms:
NewTabPage.Interests.ImageDownloadSuccess
NewTabPage.Interests.InterestsFetchSuccess
NewTabPage.Interests.NumInterests

UserActions:
MobileNTP.Interests.Click
MobileNTP.Interests.Dismissed

Also updated the NewTabPage.ActionAndroid histogram for snippets and interests
clicks.

Depends on https://codereview.chromium.org/1459593002/

Saving some intrusive changes till the dependent code is submitted.

BUG=537145,521030
==========

[knn, 2015-12-09 07:26:10]

knn@chromium.org changed reviewers:
+ asvitkine@chromium.org, bauerb@chromium.org, newt@chromium.org

[knn, 2015-12-09 07:26:11]

PTAL. Thanks!

[Bernhard Bauer, 2015-12-09 11:45:33]

lgtm

[Alexei Svitkine (slow), 2015-12-09 16:15:57]

https://codereview.chromium.org/1487373004/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ntp/InterestsPage.java
(right):

https://codereview.chromium.org/1487373004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/InterestsPage.java:73:
"NewTabPage.Interests.NumInterests", interestList.size());
Why sparse and not counts?

https://codereview.chromium.org/1487373004/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1487373004/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:29446: +<histogram
name="NewTabPage.Interests.NumInterests">
Add a units=

[newt (away), 2015-12-09 19:12:50]

NewTabPage.ActionAndroid changes and related code changes lgtm. I didn't look at
the other metrics.

[knn, 2015-12-10 06:57:17]

Alexei, PTAL. Thanks!

https://codereview.chromium.org/1487373004/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ntp/InterestsPage.java
(right):

https://codereview.chromium.org/1487373004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/InterestsPage.java:73:
"NewTabPage.Interests.NumInterests", interestList.size());
On 2015/12/09 16:15:57, Alexei Svitkine (slow) wrote:
> Why sparse and not counts?

The same rationale as when we discussed NewTabPage.Snippets.NumArticles,
NewTabPage.NumberOfTiles:
Prefer exact counts
Number of items < 30
Number should be roughly constant for a user
Sparse histograms seem cleaner than putting artificial bounds like here
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
which will have to be updated if the number of items changes like due to the
IconNTP experiment.

https://codereview.chromium.org/1487373004/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1487373004/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:29446: +<histogram
name="NewTabPage.Interests.NumInterests">
On 2015/12/09 16:15:57, Alexei Svitkine (slow) wrote:
> Add a units=

Done.

[Alexei Svitkine (slow), 2015-12-10 16:13:47]

lgtm

https://codereview.chromium.org/1487373004/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ntp/InterestsPage.java
(right):

https://codereview.chromium.org/1487373004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/InterestsPage.java:73:
"NewTabPage.Interests.NumInterests", interestList.size());
On 2015/12/10 06:57:17, knn wrote:
> On 2015/12/09 16:15:57, Alexei Svitkine (slow) wrote:
> > Why sparse and not counts?
> 
> The same rationale as when we discussed NewTabPage.Snippets.NumArticles,
> NewTabPage.NumberOfTiles:
> Prefer exact counts
> Number of items < 30
> Number should be roughly constant for a user
> Sparse histograms seem cleaner than putting artificial bounds like here
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
> which will have to be updated if the number of items changes like due to the
> IconNTP experiment.

Please add a comment about this above the function call. Despite this making
sense in this case, it's generally unconventional to use sparse histograms for
counts, so its worth having a comment to indicate this is intentional (and why
it's ok to do).

[knn, 2015-12-16 07:40:15]

The CQ bit was checked by knn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-16 07:40:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1487373004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1487373004/60001

[commit-bot: I haz the power, 2015-12-16 07:56:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 07:56:23]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)

[knn, 2015-12-16 09:51:12]

The CQ bit was checked by knn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-16 09:51:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1487373004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1487373004/80001

[commit-bot: I haz the power, 2015-12-16 11:25:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 11:25:52]

Dry run: This issue passed the CQ dry run.

[knn, 2015-12-17 05:30:01]

https://codereview.chromium.org/1487373004/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ntp/InterestsPage.java
(right):

https://codereview.chromium.org/1487373004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/InterestsPage.java:73:
"NewTabPage.Interests.NumInterests", interestList.size());
On 2015/12/10 16:13:47, Alexei Svitkine (slow) wrote:
> On 2015/12/10 06:57:17, knn wrote:
> > On 2015/12/09 16:15:57, Alexei Svitkine (slow) wrote:
> > > Why sparse and not counts?
> > 
> > The same rationale as when we discussed NewTabPage.Snippets.NumArticles,
> > NewTabPage.NumberOfTiles:
> > Prefer exact counts
> > Number of items < 30
> > Number should be roughly constant for a user
> > Sparse histograms seem cleaner than putting artificial bounds like here
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
> > which will have to be updated if the number of items changes like due to the
> > IconNTP experiment.
> 
> Please add a comment about this above the function call. Despite this making
> sense in this case, it's generally unconventional to use sparse histograms for
> counts, so its worth having a comment to indicate this is intentional (and why
> it's ok to do).

Done.

[knn, 2015-12-17 05:31:05]

The CQ bit was checked by knn@chromium.org

[knn, 2015-12-17 05:31:05]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
newt@chromium.org, asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1487373004/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2015-12-17 05:32:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1487373004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1487373004/80001

[commit-bot: I haz the power, 2015-12-17 06:45:06]

Description was changed from

==========
Metrics for user interests shown on the NTP.

Histograms:
NewTabPage.Interests.ImageDownloadSuccess
NewTabPage.Interests.InterestsFetchSuccess
NewTabPage.Interests.NumInterests

UserActions:
MobileNTP.Interests.Click
MobileNTP.Interests.Dismissed

Also updated the NewTabPage.ActionAndroid histogram for snippets and interests
clicks.

Depends on https://codereview.chromium.org/1459593002/

Saving some intrusive changes till the dependent code is submitted.

BUG=537145,521030
==========

to

==========
Metrics for user interests shown on the NTP.

Histograms:
NewTabPage.Interests.ImageDownloadSuccess
NewTabPage.Interests.InterestsFetchSuccess
NewTabPage.Interests.NumInterests

UserActions:
MobileNTP.Interests.Click
MobileNTP.Interests.Dismissed

Also updated the NewTabPage.ActionAndroid histogram for snippets and interests
clicks.

Depends on https://codereview.chromium.org/1459593002/

Saving some intrusive changes till the dependent code is submitted.

BUG=537145,521030
==========

[commit-bot: I haz the power, 2015-12-17 06:45:07]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-12-17 06:45:57]

Description was changed from

==========
Metrics for user interests shown on the NTP.

Histograms:
NewTabPage.Interests.ImageDownloadSuccess
NewTabPage.Interests.InterestsFetchSuccess
NewTabPage.Interests.NumInterests

UserActions:
MobileNTP.Interests.Click
MobileNTP.Interests.Dismissed

Also updated the NewTabPage.ActionAndroid histogram for snippets and interests
clicks.

Depends on https://codereview.chromium.org/1459593002/

Saving some intrusive changes till the dependent code is submitted.

BUG=537145,521030
==========

to

==========
Metrics for user interests shown on the NTP.

Histograms:
NewTabPage.Interests.ImageDownloadSuccess
NewTabPage.Interests.InterestsFetchSuccess
NewTabPage.Interests.NumInterests

UserActions:
MobileNTP.Interests.Click
MobileNTP.Interests.Dismissed

Also updated the NewTabPage.ActionAndroid histogram for snippets and interests
clicks.

Depends on https://codereview.chromium.org/1459593002/

Saving some intrusive changes till the dependent code is submitted.

BUG=537145,521030

Committed: https://crrev.com/8430ab46caf6988e34d8a6503822eb4e71f90e04
Cr-Commit-Position: refs/heads/master@{#365769}
==========

[commit-bot: I haz the power, 2015-12-17 06:45:57]

Patchset 5 (id:??) landed as
https://crrev.com/8430ab46caf6988e34d8a6503822eb4e71f90e04
Cr-Commit-Position: refs/heads/master@{#365769}