chrome/android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsItemView.java - Issue 1487373004: Metrics for user interests shown on the NTP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsItemView.java

Issue 1487373004: Metrics for user interests shown on the NTP. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@int

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsPage.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsItemView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsItemView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsItemView.java

index 06bed8c93c18a42c71e89e8267f29f0c941eda15..62d11419d7f58557c773853c43167d28ce99fc0f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsItemView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsItemView.java

@@ -26,6 +26,7 @@ import android.view.View.OnClickListener;

import org.chromium.base.Log;

import org.chromium.base.ObserverList;

+import org.chromium.base.metrics.RecordHistogram;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.ntp.interests.InterestsPage.InterestsClickListener;

import org.chromium.chrome.browser.ntp.interests.InterestsService.Interest;

@@ -230,9 +231,10 @@ class InterestsItemView extends AppCompatTextView implements OnClickListener {

private class ImageDownloadedCallback {

public void onImageDownloaded(Drawable image, String url) {

- if (image == null) {

- return;

- }

+ boolean imageDownloadSuccess = image != null;

+ RecordHistogram.recordBooleanHistogram(

+ "NewTabPage.Interests.ImageDownloadSuccess", imageDownloadSuccess);

+ if (!imageDownloadSuccess) return;

// If the Interest this View is displaying has changed while downloading, do not update

// the image.

if (TextUtils.equals(url, mInterest.getImageUrl())) {