chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetCardItemViewHolder.java - Issue 1487373004: Metrics for user interests shown on the NTP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetCardItemViewHolder.java

Issue 1487373004: Metrics for user interests shown on the NTP. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@int

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/interests/InterestsPage.java ('k') | tools/metrics/actions/actions.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetCardItemViewHolder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetCardItemViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetCardItemViewHolder.java

index 3c99bbe37b6ef3801fda634b0b9b01fe8e805cf7..14adb831a8e711e4320d0dd12972f341e363cea7 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetCardItemViewHolder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetCardItemViewHolder.java

@@ -14,6 +14,7 @@ import android.widget.TextView;

import org.chromium.base.metrics.RecordHistogram;

import org.chromium.base.metrics.RecordUserAction;

import org.chromium.chrome.R;

+import org.chromium.chrome.browser.ntp.NewTabPageUma;

import org.chromium.chrome.browser.ntp.snippets.SnippetsManager.SnippetArticle;

import org.chromium.chrome.browser.ntp.snippets.SnippetsManager.SnippetListItem;

@@ -64,6 +65,7 @@ class SnippetCardItemViewHolder extends SnippetListItemViewHolder implements Vie

"NewTabPage.Snippets.CardClicked", mPosition);

RecordHistogram.recordEnumeratedHistogram(SnippetsManager.SNIPPETS_STATE_HISTOGRAM,

SnippetsManager.SNIPPETS_CLICKED, SnippetsManager.NUM_SNIPPETS_ACTIONS);

+ NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_SNIPPET);

}

});

cardView.addOnAttachStateChangeListener(new View.OnAttachStateChangeListener() {