Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html

Issue 1487063002: Stop requiring NotificationAction action and title to be non-empty (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/notifications/NotificationData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html b/third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html
index 813d6499a83202908d40c12422dfef7a43c81556..5110ca78a6e33dbe9845364daeaa854f77f1d72a 100644
--- a/third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html
+++ b/third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html
@@ -48,40 +48,6 @@
}).catch(unreached_rejection(test));
}, 'showNotification() must reject if a NotificationAction has no title.');
-
- async_test(function(test) {
- var scope = 'resources/scope/' + location.pathname + "/emptyaction";
-
- getActiveServiceWorkerWithMessagePort(test, script, scope).then(function(workerInfo) {
- assert_inherits(workerInfo.registration, 'showNotification', 'showNotification() must be exposed.');
-
- workerInfo.registration.showNotification('Title', {
- actions: [{ action: "", title: "Foo" }]
- }).then(unreached_fulfillment(test)).catch(function(error) {
- assert_equals(error.name, 'TypeError');
- assert_equals(error.message, "Failed to execute 'showNotification' on 'ServiceWorkerRegistration': NotificationAction `action` must not be empty.");
- test.done();
- });
- }).catch(unreached_rejection(test));
-
- }, 'showNotification() must reject if a NotificationAction has an empty action.');
-
- async_test(function(test) {
- var scope = 'resources/scope/' + location.pathname + "/emptytitle";
-
- getActiveServiceWorkerWithMessagePort(test, script, scope).then(function(workerInfo) {
- assert_inherits(workerInfo.registration, 'showNotification', 'showNotification() must be exposed.');
-
- workerInfo.registration.showNotification('Title', {
- actions: [{ action: "foo", title: "" }]
- }).then(unreached_fulfillment(test)).catch(function(error) {
- assert_equals(error.name, 'TypeError');
- assert_equals(error.message, "Failed to execute 'showNotification' on 'ServiceWorkerRegistration': NotificationAction `title` must not be empty.");
- test.done();
- });
- }).catch(unreached_rejection(test));
-
- }, 'showNotification() must reject if a NotificationAction has an empty title.');
</script>
</body>
</html>
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/notifications/NotificationData.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698