third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html - Issue 1487063002: Stop requiring NotificationAction action and title to be non-empty

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html

Issue 1487063002: Stop requiring NotificationAction action and title to be non-empty (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Notifications: Check that showNotifications rejects if actions is set incorrectly.</title>	4 <title>Notifications: Check that showNotifications rejects if actions is set incorrectly.</title>

5 <script src="../resources/testharness.js"></script>	5 <script src="../resources/testharness.js"></script>

6 <script src="../resources/testharnessreport.js"></script>	6 <script src="../resources/testharnessreport.js"></script>

7 <script src="../serviceworker/resources/test-helpers.js"></script>	7 <script src="../serviceworker/resources/test-helpers.js"></script>

8 <script src="resources/test-helpers.js"></script>	8 <script src="resources/test-helpers.js"></script>

9 </head>	9 </head>

10 <body>	10 <body>

(...skipping 30 matching lines...) Expand all Loading...
41 workerInfo.registration.showNotification('Title', {	41 workerInfo.registration.showNotification('Title', {

42 actions: [{ action: "foo" }]	42 actions: [{ action: "foo" }]

43 }).then(unreached_fulfillment(test)).catch(function(error) {	43 }).then(unreached_fulfillment(test)).catch(function(error) {

44 assert_equals(error.name, 'TypeError');	44 assert_equals(error.name, 'TypeError');

45 assert_equals(error.message, "Failed to execute 'showNotificat ion' on 'ServiceWorkerRegistration': required member title is undefined.");	45 assert_equals(error.message, "Failed to execute 'showNotificat ion' on 'ServiceWorkerRegistration': required member title is undefined.");

46 test.done();	46 test.done();

47 });	47 });

48 }).catch(unreached_rejection(test));	48 }).catch(unreached_rejection(test));

49	49

50 }, 'showNotification() must reject if a NotificationAction has no title.') ;	50 }, 'showNotification() must reject if a NotificationAction has no title.') ;

51

52 async_test(function(test) {

53 var scope = 'resources/scope/' + location.pathname + "/emptyaction";

54

55 getActiveServiceWorkerWithMessagePort(test, script, scope).then(functi on(workerInfo) {

56 assert_inherits(workerInfo.registration, 'showNotification', 'show Notification() must be exposed.');

57

58 workerInfo.registration.showNotification('Title', {

59 actions: [{ action: "", title: "Foo" }]

60 }).then(unreached_fulfillment(test)).catch(function(error) {

61 assert_equals(error.name, 'TypeError');

62 assert_equals(error.message, "Failed to execute 'showNotificat ion' on 'ServiceWorkerRegistration': NotificationAction `action` must not be emp ty.");

63 test.done();

64 });

65 }).catch(unreached_rejection(test));

66

67 }, 'showNotification() must reject if a NotificationAction has an empty ac tion.');

68

69 async_test(function(test) {

70 var scope = 'resources/scope/' + location.pathname + "/emptytitle";

71

72 getActiveServiceWorkerWithMessagePort(test, script, scope).then(functi on(workerInfo) {

73 assert_inherits(workerInfo.registration, 'showNotification', 'show Notification() must be exposed.');

74

75 workerInfo.registration.showNotification('Title', {

76 actions: [{ action: "foo", title: "" }]

77 }).then(unreached_fulfillment(test)).catch(function(error) {

78 assert_equals(error.name, 'TypeError');

79 assert_equals(error.message, "Failed to execute 'showNotificat ion' on 'ServiceWorkerRegistration': NotificationAction `title` must not be empt y.");

80 test.done();

81 });

82 }).catch(unreached_rejection(test));

83

84 }, 'showNotification() must reject if a NotificationAction has an empty ti tle.');

85 </script>	51 </script>

86 </body>	52 </body>

87 </html>	53 </html>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/notifications/NotificationData.cpp » ('j') | no next file with comments »