third_party/WebKit/Source/modules/notifications/NotificationData.cpp - Issue 1487063002: Stop requiring NotificationAction action and title to be non-empty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationData.cpp

Issue 1487063002: Stop requiring NotificationAction action and title to be non-empty (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-actions-throw.html ('k') | third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationData.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationData.cpp b/third_party/WebKit/Source/modules/notifications/NotificationData.cpp

index 4052706c4241c29ad52a66f149b3e93e68dd8ab9..d7ce4f09e3ef54ffac24049d9168495d490bbd62 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationData.cpp

+++ b/third_party/WebKit/Source/modules/notifications/NotificationData.cpp

@@ -75,18 +75,8 @@ WebNotificationData createWebNotificationData(ExecutionContext* executionContext

const size_t maxActions = Notification::maxActions();

for (const NotificationAction& action : options.actions()) {

- if (action.action().isEmpty()) {

- exceptionState.throwTypeError("NotificationAction `action` must not be empty.");

- return WebNotificationData();

- }

- if (action.title().isEmpty()) {

- exceptionState.throwTypeError("NotificationAction `title` must not be empty.");

- return WebNotificationData();

- }

if (actions.size() >= maxActions)

- continue;

+ break;

WebNotificationAction webAction;

webAction.action = action.action();