Clean up some remaining obsolete coordinate-space naming.

Clean up some remaining obsolete coordinate-space naming.

I did a big renaming of long ago in r190693 that replaced uses of 'window'
with 'viewport' and some other terminology cleanups (see
http://www.chromium.org/developers/design-documents/blink-coordinate-spaces
for more details). This CL finishes off what was started there:

Renamed Widget's conversion methods from 'window' to 'root frame'. These
convert up to the coordinate space of the root widget, which is always the
root FrameView AFAIK.

Renamed Widget's conversion methods from 'view' to 'widget'. No need to
have multiple names for the same thing.

Clarified the coordinate space on a few ambiguous variables. And added
some clarifying comments and TODOs.

BUG=371902
Committed: https://crrev.com/72a7e34e44a162e6a5226370d4a27d4eea1416cd
Cr-Commit-Position: refs/heads/master@{#362985}

[bokan, 2015-11-30 21:39:21]

Description was changed from

==========
Clean up some remaining obsolete coordinate-space naming.

I did a big renaming of long ago in r190693 that replaced uses of 'window'
with 'viewport' and some other minor terminology cleanups (see
http://www.chromium.org/developers/design-documents/blink-coordinate-spaces
for more details). This CL finishes off what was started there:

Renamed Widget's conversion methods from 'window' to 'root frame'.

Renamed Widget's conversion methods from 'view' to 'widget'.

Clarified the coordinate space on a few ambiguous variables.

BUG=371902
==========

to

==========
Clean up some remaining obsolete coordinate-space naming.

I did a big renaming of long ago in r190693 that replaced uses of 'window'
with 'viewport' and some other terminology cleanups (see
http://www.chromium.org/developers/design-documents/blink-coordinate-spaces
for more details). This CL finishes off what was started there:

Renamed Widget's conversion methods from 'window' to 'root frame'. These
convert up to the coordinate space of the root widget, which is always the
root FrameView AFAIK.

Renamed Widget's conversion methods from 'view' to 'widget'. No need to
have multiple names for the same thing.

Clarified the coordinate space on a few ambiguous variables. And added
some clarifying comments and TODOs.

BUG=371902
==========

[bokan, 2015-11-30 21:39:21]

bokan@chromium.org changed reviewers:
+ rbyers@chromium.org

[bokan, 2015-11-30 21:39:43]

ptal, not urgent.

[Rick Byers, 2015-12-02 20:22:01]

LGTM

[bokan, 2015-12-02 20:24:02]

+avi@ for content/renderer
+vollick@ for Source/platform

[bokan, 2015-12-02 20:24:31]

bokan@chromium.org changed reviewers:
+ avi@chromium.org, vollick@chromium.org

[bokan, 2015-12-02 20:24:47]

On 2015/12/02 20:24:02, bokan wrote:
> +avi@ for content/renderer
> +vollick@ for Source/platform

Actually added reviewers this time.

[bokan, 2015-12-02 20:27:03]

bokan@chromium.org changed reviewers:
- vollick@chromium.org

[bokan, 2015-12-02 20:27:19]

On 2015/12/02 20:24:47, bokan wrote:
> On 2015/12/02 20:24:02, bokan wrote:
> > +avi@ for content/renderer
> > +vollick@ for Source/platform
> 
> Actually added reviewers this time.

-vollick@ since rbyers@ has WebKit superpowers.

[Avi (use Gerrit), 2015-12-02 21:14:11]

lgtm

content stamp

[bokan, 2015-12-02 21:14:42]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2015-12-02 21:15:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1486743002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1486743002/40001

[commit-bot: I haz the power, 2015-12-02 21:31:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-02 21:31:57]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[bokan, 2015-12-02 21:36:23]

The CQ bit was checked by bokan@chromium.org

[bokan, 2015-12-02 21:36:23]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/1486743002/#ps80001
(title: "Fixed Mac compile")

[commit-bot: I haz the power, 2015-12-02 21:38:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1486743002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1486743002/80001

[commit-bot: I haz the power, 2015-12-03 00:43:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 00:43:13]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bokan, 2015-12-03 14:46:33]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2015-12-03 14:46:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1486743002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1486743002/80001

[commit-bot: I haz the power, 2015-12-03 15:46:35]

Description was changed from

==========
Clean up some remaining obsolete coordinate-space naming.

I did a big renaming of long ago in r190693 that replaced uses of 'window'
with 'viewport' and some other terminology cleanups (see
http://www.chromium.org/developers/design-documents/blink-coordinate-spaces
for more details). This CL finishes off what was started there:

Renamed Widget's conversion methods from 'window' to 'root frame'. These
convert up to the coordinate space of the root widget, which is always the
root FrameView AFAIK.

Renamed Widget's conversion methods from 'view' to 'widget'. No need to
have multiple names for the same thing.

Clarified the coordinate space on a few ambiguous variables. And added
some clarifying comments and TODOs.

BUG=371902
==========

to

==========
Clean up some remaining obsolete coordinate-space naming.

I did a big renaming of long ago in r190693 that replaced uses of 'window'
with 'viewport' and some other terminology cleanups (see
http://www.chromium.org/developers/design-documents/blink-coordinate-spaces
for more details). This CL finishes off what was started there:

Renamed Widget's conversion methods from 'window' to 'root frame'. These
convert up to the coordinate space of the root widget, which is always the
root FrameView AFAIK.

Renamed Widget's conversion methods from 'view' to 'widget'. No need to
have multiple names for the same thing.

Clarified the coordinate space on a few ambiguous variables. And added
some clarifying comments and TODOs.

BUG=371902
==========

[commit-bot: I haz the power, 2015-12-03 15:46:36]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-12-03 15:47:38]

Description was changed from

==========
Clean up some remaining obsolete coordinate-space naming.

I did a big renaming of long ago in r190693 that replaced uses of 'window'
with 'viewport' and some other terminology cleanups (see
http://www.chromium.org/developers/design-documents/blink-coordinate-spaces
for more details). This CL finishes off what was started there:

Renamed Widget's conversion methods from 'window' to 'root frame'. These
convert up to the coordinate space of the root widget, which is always the
root FrameView AFAIK.

Renamed Widget's conversion methods from 'view' to 'widget'. No need to
have multiple names for the same thing.

Clarified the coordinate space on a few ambiguous variables. And added
some clarifying comments and TODOs.

BUG=371902
==========

to

==========
Clean up some remaining obsolete coordinate-space naming.

I did a big renaming of long ago in r190693 that replaced uses of 'window'
with 'viewport' and some other terminology cleanups (see
http://www.chromium.org/developers/design-documents/blink-coordinate-spaces
for more details). This CL finishes off what was started there:

Renamed Widget's conversion methods from 'window' to 'root frame'. These
convert up to the coordinate space of the root widget, which is always the
root FrameView AFAIK.

Renamed Widget's conversion methods from 'view' to 'widget'. No need to
have multiple names for the same thing.

Clarified the coordinate space on a few ambiguous variables. And added
some clarifying comments and TODOs.

BUG=371902

Committed: https://crrev.com/72a7e34e44a162e6a5226370d4a27d4eea1416cd
Cr-Commit-Position: refs/heads/master@{#362985}
==========

[commit-bot: I haz the power, 2015-12-03 15:47:39]

Patchset 5 (id:??) landed as
https://crrev.com/72a7e34e44a162e6a5226370d4a27d4eea1416cd
Cr-Commit-Position: refs/heads/master@{#362985}