third_party/WebKit/Source/core/page/PrintContext.cpp - Issue 1486743002: Clean up some remaining obsolete coordinate-space naming.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/PrintContext.cpp

Issue 1486743002: Clean up some remaining obsolete coordinate-space naming. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed Mac compile Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorInputAgent.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/PrintContext.cpp

diff --git a/third_party/WebKit/Source/core/page/PrintContext.cpp b/third_party/WebKit/Source/core/page/PrintContext.cpp

index 3cfff3d8a8ec62b65b6008c0788c999a2df34fcb..4808b8a694c3ecb7455254d46c8f16b6d2bff452 100644

--- a/third_party/WebKit/Source/core/page/PrintContext.cpp

+++ b/third_party/WebKit/Source/core/page/PrintContext.cpp

@@ -244,7 +244,10 @@ void PrintContext::outputLinkedDestinations(SkCanvas* canvas, const IntRect& pag

if (!layoutObject || !layoutObject->frameView())

continue;

IntRect boundingBox = layoutObject->absoluteBoundingBoxRect();

- boundingBox = layoutObject->frameView()->convertToContainingWindow(boundingBox);

+ // TODO(bokan): boundingBox looks to be in content coordinates but

+ // convertToRootFrame doesn't apply scroll offsets when converting up to

+ // the root frame.

+ boundingBox = layoutObject->frameView()->convertToRootFrame(boundingBox);

if (!pageRect.intersects(boundingBox))

continue;

IntPoint point = boundingBox.minXMinYCorner();