third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp - Issue 1486743002: Clean up some remaining obsolete coordinate-space naming.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp

Issue 1486743002: Clean up some remaining obsolete coordinate-space naming. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed Mac compile Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollbarThemeClient.h ('k') | third_party/WebKit/Source/web/WebInputEventConversion.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp b/third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp

index ae87939ae4b0c1fc6aeff156bc9d4c3942292f04..c3677371e396128282f42f5b8f83331dec239a60 100644

--- a/third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp

+++ b/third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp

@@ -127,7 +127,7 @@ void ValidationMessageClientImpl::checkAnchorStatus(Timer<ValidationMessageClien

// FIXME: This intersection eliminates the part of the rect outside the root view.

// If this is meant as a visiblity test, intersecting it against the viewport rect

// likely makes more sense.

- newAnchorRectInViewport = intersection(currentView()->convertToContainingWindow(currentView()->boundsRect()), newAnchorRectInViewport);

+ newAnchorRectInViewport = intersection(currentView()->convertToRootFrame(currentView()->boundsRect()), newAnchorRectInViewport);

if (newAnchorRectInViewport.isEmpty()) {

hideValidationMessage(*m_currentAnchor);

return;