third_party/WebKit/Source/platform/exported/WebScrollbarThemeClientImpl.cpp - Issue 1486743002: Clean up some remaining obsolete coordinate-space naming.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/exported/WebScrollbarThemeClientImpl.cpp

Issue 1486743002: Clean up some remaining obsolete coordinate-space naming. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed Mac compile Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/exported/WebScrollbarThemeClientImpl.h ('k') | third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/exported/WebScrollbarThemeClientImpl.cpp

diff --git a/third_party/WebKit/Source/platform/exported/WebScrollbarThemeClientImpl.cpp b/third_party/WebKit/Source/platform/exported/WebScrollbarThemeClientImpl.cpp

index cc078eb82e856fe098bc2090d406ff59961ff4b5..83ab99dba1baa6a091acf11e7c46bab77b360346 100644

--- a/third_party/WebKit/Source/platform/exported/WebScrollbarThemeClientImpl.cpp

+++ b/third_party/WebKit/Source/platform/exported/WebScrollbarThemeClientImpl.cpp

@@ -128,11 +128,11 @@ bool WebScrollbarThemeClientImpl::isScrollableAreaActive() const

return m_scrollbar->isScrollableAreaActive();

}

-IntPoint WebScrollbarThemeClientImpl::convertFromContainingWindow(const IntPoint& windowPoint) const

+IntPoint WebScrollbarThemeClientImpl::convertFromRootFrame(const IntPoint& pointInRootFrame) const

{

// Unused by Chromium scrollbar themes.

ASSERT_NOT_REACHED();

- return windowPoint;

+ return pointInRootFrame;

}

bool WebScrollbarThemeClientImpl::isCustomScrollbar() const