Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Unified Diff: media/base/pipeline_status.h

Issue 148553003: Clean up histogram'd media enum max values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/pipeline_status.h
diff --git a/media/base/pipeline_status.h b/media/base/pipeline_status.h
index a9f8585f573f06a4d3f8b8826e127db9289a9cc3..748849ff3022fccd7d82894e2797ff59c7de58ec 100644
--- a/media/base/pipeline_status.h
+++ b/media/base/pipeline_status.h
@@ -32,7 +32,9 @@ enum PipelineStatus {
DEMUXER_ERROR_NO_SUPPORTED_STREAMS = 14,
// Decoder related errors.
DECODER_ERROR_NOT_SUPPORTED = 15,
- PIPELINE_STATUS_MAX, // Must be greater than all other values logged.
+ PIPELINE_STATUS_MAX = DECODER_ERROR_NOT_SUPPORTED, // Must be equal to
scherkus (not reviewing) 2014/02/25 03:44:49 nit: instead of squeezing a comment here I'd stick
+ // largest value ever
+ // logged.
};
typedef base::Callback<void(PipelineStatus)> PipelineStatusCB;

Powered by Google App Engine
This is Rietveld 408576698