Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: media/base/channel_layout.h

Issue 148553003: Clean up histogram'd media enum max values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/base/audio_decoder_config.cc ('K') | « media/base/audio_decoder_config.cc ('k') | media/base/channel_layout.cc » ('j') | media/base/pipeline_status.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/channel_layout.h
diff --git a/media/base/channel_layout.h b/media/base/channel_layout.h
index 9354eee850d2718306166119bade0e6252401a70..7fd5dc28bc2aa72e58eee543fa03365f1311340a 100644
--- a/media/base/channel_layout.h
+++ b/media/base/channel_layout.h
@@ -99,8 +99,9 @@ enum ChannelLayout {
// Channels are not explicitly mapped to speakers.
CHANNEL_LAYOUT_DISCRETE = 29,
- // Total number of layouts.
- CHANNEL_LAYOUT_MAX // Must always be last!
+ // Max value
scherkus (not reviewing) 2014/02/25 03:44:49 combine subsequent comment w/ this one? (or replac
+ CHANNEL_LAYOUT_MAX = CHANNEL_LAYOUT_DISCRETE // Must always equal the largest
+ // entry ever logged.
};
enum Channels {
@@ -115,7 +116,7 @@ enum Channels {
BACK_CENTER,
SIDE_LEFT,
SIDE_RIGHT,
- CHANNELS_MAX
+ CHANNELS_MAX = SIDE_RIGHT, // Must always equal the largest value ever logged.
};
// Returns the expected channel position in an interleaved stream. Values of -1
« media/base/audio_decoder_config.cc ('K') | « media/base/audio_decoder_config.cc ('k') | media/base/channel_layout.cc » ('j') | media/base/pipeline_status.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698