Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: media/base/pipeline_status.h

Issue 148553003: Clean up histogram'd media enum max values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_BASE_PIPELINE_STATUS_H_ 5 #ifndef MEDIA_BASE_PIPELINE_STATUS_H_
6 #define MEDIA_BASE_PIPELINE_STATUS_H_ 6 #define MEDIA_BASE_PIPELINE_STATUS_H_
7 7
8 #include "base/callback.h" 8 #include "base/callback.h"
9 9
10 #include <string> 10 #include <string>
(...skipping 14 matching lines...) Expand all
25 PIPELINE_ERROR_COULD_NOT_RENDER = 8, 25 PIPELINE_ERROR_COULD_NOT_RENDER = 8,
26 PIPELINE_ERROR_READ = 9, 26 PIPELINE_ERROR_READ = 9,
27 PIPELINE_ERROR_OPERATION_PENDING = 10, 27 PIPELINE_ERROR_OPERATION_PENDING = 10,
28 PIPELINE_ERROR_INVALID_STATE = 11, 28 PIPELINE_ERROR_INVALID_STATE = 11,
29 // Demuxer related errors. 29 // Demuxer related errors.
30 DEMUXER_ERROR_COULD_NOT_OPEN = 12, 30 DEMUXER_ERROR_COULD_NOT_OPEN = 12,
31 DEMUXER_ERROR_COULD_NOT_PARSE = 13, 31 DEMUXER_ERROR_COULD_NOT_PARSE = 13,
32 DEMUXER_ERROR_NO_SUPPORTED_STREAMS = 14, 32 DEMUXER_ERROR_NO_SUPPORTED_STREAMS = 14,
33 // Decoder related errors. 33 // Decoder related errors.
34 DECODER_ERROR_NOT_SUPPORTED = 15, 34 DECODER_ERROR_NOT_SUPPORTED = 15,
35 PIPELINE_STATUS_MAX, // Must be greater than all other values logged. 35 PIPELINE_STATUS_MAX = DECODER_ERROR_NOT_SUPPORTED, // Must be equal to
scherkus (not reviewing) 2014/02/25 03:44:49 nit: instead of squeezing a comment here I'd stick
36 // largest value ever
37 // logged.
36 }; 38 };
37 39
38 typedef base::Callback<void(PipelineStatus)> PipelineStatusCB; 40 typedef base::Callback<void(PipelineStatus)> PipelineStatusCB;
39 41
40 // TODO(scherkus): this should be moved alongside host interface definitions. 42 // TODO(scherkus): this should be moved alongside host interface definitions.
41 struct PipelineStatistics { 43 struct PipelineStatistics {
42 PipelineStatistics() 44 PipelineStatistics()
43 : audio_bytes_decoded(0), 45 : audio_bytes_decoded(0),
44 video_bytes_decoded(0), 46 video_bytes_decoded(0),
45 video_frames_decoded(0), 47 video_frames_decoded(0),
46 video_frames_dropped(0) { 48 video_frames_dropped(0) {
47 } 49 }
48 50
49 uint32 audio_bytes_decoded; // Should be uint64? 51 uint32 audio_bytes_decoded; // Should be uint64?
50 uint32 video_bytes_decoded; // Should be uint64? 52 uint32 video_bytes_decoded; // Should be uint64?
51 uint32 video_frames_decoded; 53 uint32 video_frames_decoded;
52 uint32 video_frames_dropped; 54 uint32 video_frames_dropped;
53 }; 55 };
54 56
55 // Used for updating pipeline statistics. 57 // Used for updating pipeline statistics.
56 typedef base::Callback<void(const PipelineStatistics&)> StatisticsCB; 58 typedef base::Callback<void(const PipelineStatistics&)> StatisticsCB;
57 59
58 } // namespace media 60 } // namespace media
59 61
60 #endif // MEDIA_BASE_PIPELINE_STATUS_H_ 62 #endif // MEDIA_BASE_PIPELINE_STATUS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698