Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: media/ffmpeg/ffmpeg_common.cc

Issue 148553003: Clean up histogram'd media enum max values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/ffmpeg/ffmpeg_common.cc
diff --git a/media/ffmpeg/ffmpeg_common.cc b/media/ffmpeg/ffmpeg_common.cc
index 6e7bd155cd80d9f103cfbd7670e8e5381263cd3e..c5423766f7ff755456326e39bf648cd7ba6cd6ea 100644
--- a/media/ffmpeg/ffmpeg_common.cc
+++ b/media/ffmpeg/ffmpeg_common.cc
@@ -389,9 +389,12 @@ void AVStreamToVideoDecoderConfig(
visible_rect.size(), aspect_ratio.num, aspect_ratio.den);
if (record_stats) {
+ // Note the 'PRESUBMIT_IGNORE_UMA_MAX below, this silences the PRESUBMIT.py
scherkus (not reviewing) 2014/02/25 03:44:49 nit: remove leading ' ... or did you mean to termi
+ // check for uma enum max usage, since we're abusing
+ // UMA_HISTOGRAM_ENUMERATION to report a discrete value.
UMA_HISTOGRAM_ENUMERATION("Media.VideoColorRange",
stream->codec->color_range,
- AVCOL_RANGE_NB);
+ AVCOL_RANGE_NB); // PRESUBMIT_IGNORE_UMA_MAX
}
VideoFrame::Format format = PixelFormatToVideoFormat(stream->codec->pix_fmt);

Powered by Google App Engine
This is Rietveld 408576698