Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1617)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1484893003: [debugger] simplify reloc info for debug break slots. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] simplify reloc info for debug break slots. The new step-in implementation no longer tries to predict the step-in target, so we don't need the arguments count nor call type anymore. R=verwaest@chromium.org Committed: https://crrev.com/531dde9f80cb4e6aaa03083b42285c319a47867f Cr-Commit-Position: refs/heads/master@{#32516}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -137 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/assembler-arm64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/assembler-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/assembler.h View 5 chunks +4 lines, -12 lines 0 comments Download
M src/assembler.cc View 6 chunks +4 lines, -18 lines 0 comments Download
M src/debug/arm/debug-arm.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/debug/arm64/debug-arm64.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/debug/debug.h View 2 chunks +1 line, -11 lines 0 comments Download
M src/debug/debug.cc View 3 chunks +1 line, -7 lines 0 comments Download
M src/debug/ia32/debug-ia32.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/debug/mips/debug-mips.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/debug/mips64/debug-mips64.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/debug/x64/debug-x64.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +5 lines, -2 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +2 lines, -14 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/assembler-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/assembler-mips64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/assembler-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Yang
5 years ago (2015-12-01 11:54:39 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484893003/1
5 years ago (2015-12-01 11:55:05 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-01 14:03:03 UTC) #5
Yang
On 2015/12/01 14:03:03, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years ago (2015-12-02 07:55:08 UTC) #6
Toon Verwaest
lgtm
5 years ago (2015-12-02 13:36:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484893003/1
5 years ago (2015-12-02 13:45:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 14:13:46 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-02 14:14:35 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/531dde9f80cb4e6aaa03083b42285c319a47867f
Cr-Commit-Position: refs/heads/master@{#32516}

Powered by Google App Engine
This is Rietveld 408576698