Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: src/full-codegen/full-codegen.cc

Issue 1484893003: [debugger] simplify reloc info for debug break slots. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/full-codegen.h ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/full-codegen/full-codegen.h" 5 #include "src/full-codegen/full-codegen.h"
6 6
7 #include "src/ast/ast.h" 7 #include "src/ast/ast.h"
8 #include "src/ast/ast-numbering.h" 8 #include "src/ast/ast-numbering.h"
9 #include "src/ast/prettyprinter.h" 9 #include "src/ast/prettyprinter.h"
10 #include "src/ast/scopeinfo.h" 10 #include "src/ast/scopeinfo.h"
(...skipping 584 matching lines...) Expand 10 before | Expand all | Expand 10 after
595 595
596 void FullCodeGenerator::SetExpressionAsStatementPosition(Expression* expr) { 596 void FullCodeGenerator::SetExpressionAsStatementPosition(Expression* expr) {
597 if (expr->position() == RelocInfo::kNoPosition) return; 597 if (expr->position() == RelocInfo::kNoPosition) return;
598 bool recorded = RecordStatementPosition(masm_, expr->position()); 598 bool recorded = RecordStatementPosition(masm_, expr->position());
599 if (recorded && info_->is_debug()) { 599 if (recorded && info_->is_debug()) {
600 DebugCodegen::GenerateSlot(masm_, RelocInfo::DEBUG_BREAK_SLOT_AT_POSITION); 600 DebugCodegen::GenerateSlot(masm_, RelocInfo::DEBUG_BREAK_SLOT_AT_POSITION);
601 } 601 }
602 } 602 }
603 603
604 604
605 void FullCodeGenerator::SetCallPosition(Expression* expr, int argc) { 605 void FullCodeGenerator::SetCallPosition(Expression* expr) {
606 if (expr->position() == RelocInfo::kNoPosition) return; 606 if (expr->position() == RelocInfo::kNoPosition) return;
607 RecordPosition(masm_, expr->position()); 607 RecordPosition(masm_, expr->position());
608 if (info_->is_debug()) { 608 if (info_->is_debug()) {
609 // Always emit a debug break slot before a call. 609 // Always emit a debug break slot before a call.
610 DebugCodegen::GenerateSlot(masm_, RelocInfo::DEBUG_BREAK_SLOT_AT_CALL, 610 DebugCodegen::GenerateSlot(masm_, RelocInfo::DEBUG_BREAK_SLOT_AT_CALL);
611 argc);
612 } 611 }
613 } 612 }
614 613
615
616 void FullCodeGenerator::SetConstructCallPosition(Expression* expr, int argc) {
617 if (expr->position() == RelocInfo::kNoPosition) return;
618 RecordPosition(masm_, expr->position());
619 if (info_->is_debug()) {
620 // Always emit a debug break slot before a construct call.
621 DebugCodegen::GenerateSlot(
622 masm_, RelocInfo::DEBUG_BREAK_SLOT_AT_CONSTRUCT_CALL, argc);
623 }
624 }
625
626 614
627 void FullCodeGenerator::VisitSuperPropertyReference( 615 void FullCodeGenerator::VisitSuperPropertyReference(
628 SuperPropertyReference* super) { 616 SuperPropertyReference* super) {
629 __ CallRuntime(Runtime::kThrowUnsupportedSuperError, 0); 617 __ CallRuntime(Runtime::kThrowUnsupportedSuperError, 0);
630 } 618 }
631 619
632 620
633 void FullCodeGenerator::VisitSuperCallReference(SuperCallReference* super) { 621 void FullCodeGenerator::VisitSuperCallReference(SuperCallReference* super) {
634 __ CallRuntime(Runtime::kThrowUnsupportedSuperError, 0); 622 __ CallRuntime(Runtime::kThrowUnsupportedSuperError, 0);
635 } 623 }
(...skipping 1106 matching lines...) Expand 10 before | Expand all | Expand 10 after
1742 return var->mode() == CONST_LEGACY || var->scope()->is_nonlinear() || 1730 return var->mode() == CONST_LEGACY || var->scope()->is_nonlinear() ||
1743 var->initializer_position() >= proxy->position(); 1731 var->initializer_position() >= proxy->position();
1744 } 1732 }
1745 1733
1746 1734
1747 #undef __ 1735 #undef __
1748 1736
1749 1737
1750 } // namespace internal 1738 } // namespace internal
1751 } // namespace v8 1739 } // namespace v8
OLDNEW
« no previous file with comments | « src/full-codegen/full-codegen.h ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698