Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: src/debug/ia32/debug-ia32.cc

Issue 1484893003: [debugger] simplify reloc info for debug break slots. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug/debug.cc ('k') | src/debug/mips/debug-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/ia32/frames-ia32.h" 9 #include "src/ia32/frames-ia32.h"
10 10
11 namespace v8 { 11 namespace v8 {
12 namespace internal { 12 namespace internal {
13 13
14 #define __ ACCESS_MASM(masm) 14 #define __ ACCESS_MASM(masm)
15 15
16 16
17 void EmitDebugBreakSlot(MacroAssembler* masm) { 17 void EmitDebugBreakSlot(MacroAssembler* masm) {
18 Label check_codesize; 18 Label check_codesize;
19 __ bind(&check_codesize); 19 __ bind(&check_codesize);
20 __ Nop(Assembler::kDebugBreakSlotLength); 20 __ Nop(Assembler::kDebugBreakSlotLength);
21 DCHECK_EQ(Assembler::kDebugBreakSlotLength, 21 DCHECK_EQ(Assembler::kDebugBreakSlotLength,
22 masm->SizeOfCodeGeneratedSince(&check_codesize)); 22 masm->SizeOfCodeGeneratedSince(&check_codesize));
23 } 23 }
24 24
25 25
26 void DebugCodegen::GenerateSlot(MacroAssembler* masm, RelocInfo::Mode mode, 26 void DebugCodegen::GenerateSlot(MacroAssembler* masm, RelocInfo::Mode mode) {
27 int call_argc) {
28 // Generate enough nop's to make space for a call instruction. 27 // Generate enough nop's to make space for a call instruction.
29 masm->RecordDebugBreakSlot(mode, call_argc); 28 masm->RecordDebugBreakSlot(mode);
30 EmitDebugBreakSlot(masm); 29 EmitDebugBreakSlot(masm);
31 } 30 }
32 31
33 32
34 void DebugCodegen::ClearDebugBreakSlot(Isolate* isolate, Address pc) { 33 void DebugCodegen::ClearDebugBreakSlot(Isolate* isolate, Address pc) {
35 CodePatcher patcher(isolate, pc, Assembler::kDebugBreakSlotLength); 34 CodePatcher patcher(isolate, pc, Assembler::kDebugBreakSlotLength);
36 EmitDebugBreakSlot(patcher.masm()); 35 EmitDebugBreakSlot(patcher.masm());
37 } 36 }
38 37
39 38
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 136
138 137
139 const bool LiveEdit::kFrameDropperSupported = true; 138 const bool LiveEdit::kFrameDropperSupported = true;
140 139
141 #undef __ 140 #undef __
142 141
143 } // namespace internal 142 } // namespace internal
144 } // namespace v8 143 } // namespace v8
145 144
146 #endif // V8_TARGET_ARCH_IA32 145 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/debug/debug.cc ('k') | src/debug/mips/debug-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698