Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: src/mips/assembler-mips.cc

Issue 1484893003: [debugger] simplify reloc info for debug break slots. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/assembler-mips.h ('k') | src/mips64/assembler-mips64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 2878 matching lines...) Expand 10 before | Expand all | Expand 10 after
2889 *reinterpret_cast<uint32_t*>(pc_) = 2889 *reinterpret_cast<uint32_t*>(pc_) =
2890 reinterpret_cast<uint32_t>(stub->instruction_start()); 2890 reinterpret_cast<uint32_t>(stub->instruction_start());
2891 pc_ += sizeof(uint32_t); 2891 pc_ += sizeof(uint32_t);
2892 } 2892 }
2893 2893
2894 2894
2895 void Assembler::RecordRelocInfo(RelocInfo::Mode rmode, intptr_t data) { 2895 void Assembler::RecordRelocInfo(RelocInfo::Mode rmode, intptr_t data) {
2896 // We do not try to reuse pool constants. 2896 // We do not try to reuse pool constants.
2897 RelocInfo rinfo(isolate(), pc_, rmode, data, NULL); 2897 RelocInfo rinfo(isolate(), pc_, rmode, data, NULL);
2898 if (rmode >= RelocInfo::COMMENT && 2898 if (rmode >= RelocInfo::COMMENT &&
2899 rmode <= RelocInfo::DEBUG_BREAK_SLOT_AT_CONSTRUCT_CALL) { 2899 rmode <= RelocInfo::DEBUG_BREAK_SLOT_AT_CALL) {
2900 // Adjust code for new modes. 2900 // Adjust code for new modes.
2901 DCHECK(RelocInfo::IsDebugBreakSlot(rmode) 2901 DCHECK(RelocInfo::IsDebugBreakSlot(rmode)
2902 || RelocInfo::IsComment(rmode) 2902 || RelocInfo::IsComment(rmode)
2903 || RelocInfo::IsPosition(rmode)); 2903 || RelocInfo::IsPosition(rmode));
2904 // These modes do not need an entry in the constant pool. 2904 // These modes do not need an entry in the constant pool.
2905 } 2905 }
2906 if (!RelocInfo::IsNone(rinfo.rmode())) { 2906 if (!RelocInfo::IsNone(rinfo.rmode())) {
2907 // Don't record external references unless the heap will be serialized. 2907 // Don't record external references unless the heap will be serialized.
2908 if (rmode == RelocInfo::EXTERNAL_REFERENCE && 2908 if (rmode == RelocInfo::EXTERNAL_REFERENCE &&
2909 !serializer_enabled() && !emit_debug_code()) { 2909 !serializer_enabled() && !emit_debug_code()) {
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
3047 3047
3048 if (icache_flush_mode != SKIP_ICACHE_FLUSH) { 3048 if (icache_flush_mode != SKIP_ICACHE_FLUSH) {
3049 Assembler::FlushICache(isolate, pc, 2 * sizeof(int32_t)); 3049 Assembler::FlushICache(isolate, pc, 2 * sizeof(int32_t));
3050 } 3050 }
3051 } 3051 }
3052 3052
3053 } // namespace internal 3053 } // namespace internal
3054 } // namespace v8 3054 } // namespace v8
3055 3055
3056 #endif // V8_TARGET_ARCH_MIPS 3056 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/mips/assembler-mips.h ('k') | src/mips64/assembler-mips64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698