Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 1483903002: [App Banner] Use appropriate type parameters for WebCallbacks. (Closed)

Created:
5 years ago by yhirano
Modified:
5 years ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, mlamouri+watch-blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[App Banner] Use appropriate type parameters for WebCallbacks. This CL fixes a WebCallback parameter type used in App Banner. - WebAppBannerPromptResult* (ownership transferred) => WebAppBannerPromptResult& BUG=493531 Committed: https://crrev.com/2465f9886e6ad78fcfd8a111fc1bd81ed2db7bde Cr-Commit-Position: refs/heads/master@{#362139}

Patch Set 1 #

Messages

Total messages: 15 (6 generated)
yhirano
5 years ago (2015-11-30 06:47:31 UTC) #2
mlamouri (slow - plz ping)
lgtm
5 years ago (2015-11-30 11:21:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1483903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1483903002/1
5 years ago (2015-11-30 11:21:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/123072)
5 years ago (2015-11-30 11:27:51 UTC) #7
yhirano
jochen@, can you take a look at - chrome/renderer/banners/app_banner_client.cc - components/test_runner/app_banner_client.cc ?
5 years ago (2015-11-30 11:30:54 UTC) #9
jochen (gone - plz use gerrit)
lgtm
5 years ago (2015-11-30 15:57:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1483903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1483903002/1
5 years ago (2015-11-30 16:03:13 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 16:12:03 UTC) #13
commit-bot: I haz the power
5 years ago (2015-11-30 16:12:51 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2465f9886e6ad78fcfd8a111fc1bd81ed2db7bde
Cr-Commit-Position: refs/heads/master@{#362139}

Powered by Google App Engine
This is Rietveld 408576698