third_party/WebKit/Source/modules/app_banner/AppBannerCallbacks.cpp - Issue 1483903002: [App Banner] Use appropriate type parameters for WebCallbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/app_banner/AppBannerCallbacks.cpp

Issue 1483903002: [App Banner] Use appropriate type parameters for WebCallbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/app_banner/AppBannerCallbacks.h ('k') | third_party/WebKit/Source/modules/app_banner/AppBannerPromptResult.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/app_banner/AppBannerCallbacks.cpp

diff --git a/third_party/WebKit/Source/modules/app_banner/AppBannerCallbacks.cpp b/third_party/WebKit/Source/modules/app_banner/AppBannerCallbacks.cpp

index 3da3c29a6dc5eda679dcbf57ec0be562efc53c17..f01fcdbd601a40da953ac088a0d4cfc89ed300c5 100644

--- a/third_party/WebKit/Source/modules/app_banner/AppBannerCallbacks.cpp

+++ b/third_party/WebKit/Source/modules/app_banner/AppBannerCallbacks.cpp

@@ -12,9 +12,9 @@ AppBannerCallbacks::AppBannerCallbacks(UserChoiceProperty* userChoice)

{

}

-void AppBannerCallbacks::onSuccess(WebAppBannerPromptResult* result)

+void AppBannerCallbacks::onSuccess(const WebAppBannerPromptResult& result)

{

- m_userChoice->resolve(AppBannerPromptResult::take(adoptPtr(result)));

+ m_userChoice->resolve(AppBannerPromptResult::create(result.platform, result.outcome));

}

} // namespace blink