third_party/WebKit/Source/modules/app_banner/AppBannerCallbacks.h - Issue 1483903002: [App Banner] Use appropriate type parameters for WebCallbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/app_banner/AppBannerCallbacks.h

Issue 1483903002: [App Banner] Use appropriate type parameters for WebCallbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/test_runner/app_banner_client.cc ('k') | third_party/WebKit/Source/modules/app_banner/AppBannerCallbacks.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/app_banner/AppBannerCallbacks.h

diff --git a/third_party/WebKit/Source/modules/app_banner/AppBannerCallbacks.h b/third_party/WebKit/Source/modules/app_banner/AppBannerCallbacks.h

index 61ad0d39adce620020b90d58f344f1cf6d3a81dc..c0e59103ee4e1648d88a55f6a5a107de441cae50 100644

--- a/third_party/WebKit/Source/modules/app_banner/AppBannerCallbacks.h

+++ b/third_party/WebKit/Source/modules/app_banner/AppBannerCallbacks.h

@@ -19,7 +19,7 @@ public:

~AppBannerCallbacks() override = default;

// WebAppBannerCallbacks overrides.

- void onSuccess(WebAppBannerPromptResult*) override;

+ void onSuccess(const WebAppBannerPromptResult&) override;

private:

Persistent<UserChoiceProperty> m_userChoice;

« no previous file with comments | « components/test_runner/app_banner_client.cc ('k') | third_party/WebKit/Source/modules/app_banner/AppBannerCallbacks.cpp » ('j') | no next file with comments »