Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: components/test_runner/app_banner_client.cc

Issue 1483903002: [App Banner] Use appropriate type parameters for WebCallbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/app_banner_client.cc
diff --git a/components/test_runner/app_banner_client.cc b/components/test_runner/app_banner_client.cc
index 6e3afbddf45e7d3245f0efc285144ee2b7e22f89..de85dc88884f5b9d6f452df52961f7fd1616cc9f 100644
--- a/components/test_runner/app_banner_client.cc
+++ b/components/test_runner/app_banner_client.cc
@@ -28,16 +28,12 @@ void AppBannerClient::ResolvePromise(int request_id,
if (!callbacks)
return;
- scoped_ptr<blink::WebAppBannerPromptResult> result(
- new blink::WebAppBannerPromptResult(
- blink::WebString::fromUTF8(resolve_platform),
- blink::WebAppBannerPromptResult::Outcome::Accepted));
-
// If no platform has been set, treat it as dismissal.
- if (resolve_platform.empty())
- result->outcome = blink::WebAppBannerPromptResult::Outcome::Dismissed;
-
- callbacks->onSuccess(result.release());
+ callbacks->onSuccess(blink::WebAppBannerPromptResult(
+ blink::WebString::fromUTF8(resolve_platform),
+ resolve_platform.empty()
+ ? blink::WebAppBannerPromptResult::Outcome::Dismissed
+ : blink::WebAppBannerPromptResult::Outcome::Accepted));
callbacks_map_.Remove(request_id);
}
« no previous file with comments | « chrome/renderer/banners/app_banner_client.cc ('k') | third_party/WebKit/Source/modules/app_banner/AppBannerCallbacks.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698