Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1482433003: Sync cloneNode() IDL with the spec (Closed)

Created:
5 years ago by philipj_slow
Modified:
5 years ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews-html_chromium.org, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync cloneNode() IDL with the spec All internal callers pass an argument, so the default value can be in the IDL only. BUG=460722 Committed: https://crrev.com/afbe6d4ebdc87ce3826a9fadb6f0f794b34c6eac Cr-Commit-Position: refs/heads/master@{#361856}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M third_party/WebKit/Source/core/dom/Attr.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Comment.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentFragment.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.idl View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ProcessingInstruction.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Text.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ShadowRoot.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTemplateElement.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482433003/1
5 years ago (2015-11-25 22:37:01 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/71846)
5 years ago (2015-11-25 23:08:33 UTC) #4
philipj_slow
PTAL
5 years ago (2015-11-26 08:38:06 UTC) #8
haraken
LGTM
5 years ago (2015-11-26 08:42:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482433003/1
5 years ago (2015-11-26 08:46:25 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 09:32:51 UTC) #13
commit-bot: I haz the power
5 years ago (2015-11-26 09:34:37 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afbe6d4ebdc87ce3826a9fadb6f0f794b34c6eac
Cr-Commit-Position: refs/heads/master@{#361856}

Powered by Google App Engine
This is Rietveld 408576698