third_party/WebKit/Source/core/dom/shadow/ShadowRoot.idl - Issue 1482433003: Sync cloneNode() IDL with the spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/shadow/ShadowRoot.idl

Issue 1482433003: Sync cloneNode() IDL with the spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/shadow/ShadowRoot.idl

diff --git a/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.idl b/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.idl

index cfb06f2daa039241bc40baa68b6c3314b857edae..f783a41ed2386ce918b361f3ce077e62754ac058 100644

--- a/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.idl

+++ b/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.idl

@@ -42,5 +42,5 @@ interface ShadowRoot : DocumentFragment {

// interface. Here, it's used to implement "Invoking the cloneNode() method

// on a ShadowRoot instance must always throw a DATA_CLONE_ERR exception" as

// Node.cloneNode() does not have [RaisesException].

- [RaisesException] Node cloneNode([Default=Undefined] optional boolean deep);

+ [RaisesException] Node cloneNode(optional boolean deep = false);

};