third_party/WebKit/Source/core/dom/DocumentFragment.h - Issue 1482433003: Sync cloneNode() IDL with the spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/DocumentFragment.h

Issue 1482433003: Sync cloneNode() IDL with the spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/DocumentFragment.h

diff --git a/third_party/WebKit/Source/core/dom/DocumentFragment.h b/third_party/WebKit/Source/core/dom/DocumentFragment.h

index de58ffc2689152920eb57f269aa29da70308cf83..74788f62870b3f169eec641a0afd7a5a19f9fb1f 100644

--- a/third_party/WebKit/Source/core/dom/DocumentFragment.h

+++ b/third_party/WebKit/Source/core/dom/DocumentFragment.h

@@ -47,7 +47,7 @@ protected:

private:

NodeType nodeType() const final;

- PassRefPtrWillBeRawPtr<Node> cloneNode(bool deep = true) override;

+ PassRefPtrWillBeRawPtr<Node> cloneNode(bool deep) override;

bool childTypeAllowed(NodeType) const override;

bool isDocumentFragment() const = delete; // This will catch anyone doing an unnecessary check.