third_party/WebKit/Source/core/dom/Text.h - Issue 1482433003: Sync cloneNode() IDL with the spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Text.h

Issue 1482433003: Sync cloneNode() IDL with the spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Text.h

diff --git a/third_party/WebKit/Source/core/dom/Text.h b/third_party/WebKit/Source/core/dom/Text.h

index 08178b7bf70414c2eb30313fb738aac86e5e1ee7..fa8435da774ec7823f2898590016da78bd4c50dc 100644

--- a/third_party/WebKit/Source/core/dom/Text.h

+++ b/third_party/WebKit/Source/core/dom/Text.h

@@ -70,7 +70,7 @@ protected:

private:

String nodeName() const override;

- PassRefPtrWillBeRawPtr<Node> cloneNode(bool deep = true) final;

+ PassRefPtrWillBeRawPtr<Node> cloneNode(bool deep) final;

bool isTextNode() const = delete; // This will catch anyone doing an unnecessary check.