Issue 14813029: Error found in test262 on ARM: BinaryOpStub could call out to a built-in and push …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14813029: Error found in test262 on ARM: BinaryOpStub could call out to a built-in and push … (Closed)

Created:
7 years, 7 months ago by mvstanton

Modified:
7 years, 7 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Error found in test262 on ARM: BinaryOpStub could call out to a built-in and push parameters without an enclosing frame. This corrupted stackwalking. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14665

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+272 lines, -67 lines)			Patch
M	src/arm/code-stubs-arm.h	View	1 2	2 chunks	+8 lines, -3 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	1 2	9 chunks	+67 lines, -14 lines	0 comments	Download
M	src/arm/simulator-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/code-stubs.cc	View		1 chunk	+11 lines, -11 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.h	View	1 2	2 chunks	+8 lines, -4 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1 2	14 chunks	+90 lines, -14 lines	0 comments	Download
M	src/x64/code-stubs-x64.h	View	1 2	2 chunks	+8 lines, -3 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1 2	10 chunks	+79 lines, -17 lines	0 comments	Download

Total messages: 3 (0 generated)

mvstanton

Hi Ulan, Here is the abbreviated fix we discussed, thx for the review! Working on ...

7 years, 7 months ago (2013-05-14 14:01:46 UTC) #1

mvstanton

7 years, 7 months ago (2013-05-14 15:31:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r14665 (presubmit successful).