Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: src/arm/simulator-arm.cc

Issue 14813029: Error found in test262 on ARM: BinaryOpStub could call out to a built-in and push … (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Code review comments Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 394 matching lines...) Expand 10 before | Expand all | Expand 10 after
405 } 405 }
406 } 406 }
407 end = cur + words; 407 end = cur + words;
408 408
409 while (cur < end) { 409 while (cur < end) {
410 PrintF(" 0x%08x: 0x%08x %10d", 410 PrintF(" 0x%08x: 0x%08x %10d",
411 reinterpret_cast<intptr_t>(cur), *cur, *cur); 411 reinterpret_cast<intptr_t>(cur), *cur, *cur);
412 HeapObject* obj = reinterpret_cast<HeapObject*>(*cur); 412 HeapObject* obj = reinterpret_cast<HeapObject*>(*cur);
413 int value = *cur; 413 int value = *cur;
414 Heap* current_heap = v8::internal::Isolate::Current()->heap(); 414 Heap* current_heap = v8::internal::Isolate::Current()->heap();
415 if (current_heap->Contains(obj) || ((value & 1) == 0)) { 415 if (((value & 1) == 0) || current_heap->Contains(obj)) {
416 PrintF(" ("); 416 PrintF(" (");
417 if ((value & 1) == 0) { 417 if ((value & 1) == 0) {
418 PrintF("smi %d", value / 2); 418 PrintF("smi %d", value / 2);
419 } else { 419 } else {
420 obj->ShortPrint(); 420 obj->ShortPrint();
421 } 421 }
422 PrintF(")"); 422 PrintF(")");
423 } 423 }
424 PrintF("\n"); 424 PrintF("\n");
425 cur++; 425 cur++;
(...skipping 3063 matching lines...) Expand 10 before | Expand all | Expand 10 after
3489 uintptr_t address = *stack_slot; 3489 uintptr_t address = *stack_slot;
3490 set_register(sp, current_sp + sizeof(uintptr_t)); 3490 set_register(sp, current_sp + sizeof(uintptr_t));
3491 return address; 3491 return address;
3492 } 3492 }
3493 3493
3494 } } // namespace v8::internal 3494 } } // namespace v8::internal
3495 3495
3496 #endif // USE_SIMULATOR 3496 #endif // USE_SIMULATOR
3497 3497
3498 #endif // V8_TARGET_ARCH_ARM 3498 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698