Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: src/code-stubs.cc

Issue 14813029: Error found in test262 on ARM: BinaryOpStub could call out to a built-in and push … (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Code review comments Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/simulator-arm.cc ('k') | src/ia32/code-stubs-ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
225 } 225 }
226 } 226 }
227 227
228 228
229 #define __ ACCESS_MASM(masm) 229 #define __ ACCESS_MASM(masm)
230 230
231 231
232 void BinaryOpStub::GenerateCallRuntime(MacroAssembler* masm) { 232 void BinaryOpStub::GenerateCallRuntime(MacroAssembler* masm) {
233 switch (op_) { 233 switch (op_) {
234 case Token::ADD: 234 case Token::ADD:
235 __ InvokeBuiltin(Builtins::ADD, JUMP_FUNCTION); 235 __ InvokeBuiltin(Builtins::ADD, CALL_FUNCTION);
236 break; 236 break;
237 case Token::SUB: 237 case Token::SUB:
238 __ InvokeBuiltin(Builtins::SUB, JUMP_FUNCTION); 238 __ InvokeBuiltin(Builtins::SUB, CALL_FUNCTION);
239 break; 239 break;
240 case Token::MUL: 240 case Token::MUL:
241 __ InvokeBuiltin(Builtins::MUL, JUMP_FUNCTION); 241 __ InvokeBuiltin(Builtins::MUL, CALL_FUNCTION);
242 break; 242 break;
243 case Token::DIV: 243 case Token::DIV:
244 __ InvokeBuiltin(Builtins::DIV, JUMP_FUNCTION); 244 __ InvokeBuiltin(Builtins::DIV, CALL_FUNCTION);
245 break; 245 break;
246 case Token::MOD: 246 case Token::MOD:
247 __ InvokeBuiltin(Builtins::MOD, JUMP_FUNCTION); 247 __ InvokeBuiltin(Builtins::MOD, CALL_FUNCTION);
248 break; 248 break;
249 case Token::BIT_OR: 249 case Token::BIT_OR:
250 __ InvokeBuiltin(Builtins::BIT_OR, JUMP_FUNCTION); 250 __ InvokeBuiltin(Builtins::BIT_OR, CALL_FUNCTION);
251 break; 251 break;
252 case Token::BIT_AND: 252 case Token::BIT_AND:
253 __ InvokeBuiltin(Builtins::BIT_AND, JUMP_FUNCTION); 253 __ InvokeBuiltin(Builtins::BIT_AND, CALL_FUNCTION);
254 break; 254 break;
255 case Token::BIT_XOR: 255 case Token::BIT_XOR:
256 __ InvokeBuiltin(Builtins::BIT_XOR, JUMP_FUNCTION); 256 __ InvokeBuiltin(Builtins::BIT_XOR, CALL_FUNCTION);
257 break; 257 break;
258 case Token::SAR: 258 case Token::SAR:
259 __ InvokeBuiltin(Builtins::SAR, JUMP_FUNCTION); 259 __ InvokeBuiltin(Builtins::SAR, CALL_FUNCTION);
260 break; 260 break;
261 case Token::SHR: 261 case Token::SHR:
262 __ InvokeBuiltin(Builtins::SHR, JUMP_FUNCTION); 262 __ InvokeBuiltin(Builtins::SHR, CALL_FUNCTION);
263 break; 263 break;
264 case Token::SHL: 264 case Token::SHL:
265 __ InvokeBuiltin(Builtins::SHL, JUMP_FUNCTION); 265 __ InvokeBuiltin(Builtins::SHL, CALL_FUNCTION);
266 break; 266 break;
267 default: 267 default:
268 UNREACHABLE(); 268 UNREACHABLE();
269 } 269 }
270 } 270 }
271 271
272 272
273 #undef __ 273 #undef __
274 274
275 275
(...skipping 455 matching lines...) Expand 10 before | Expand all | Expand 10 after
731 } else if (argument_count >= 2) { 731 } else if (argument_count >= 2) {
732 argument_count_ = MORE_THAN_ONE; 732 argument_count_ = MORE_THAN_ONE;
733 } else { 733 } else {
734 UNREACHABLE(); 734 UNREACHABLE();
735 } 735 }
736 ArrayConstructorStubBase::GenerateStubsAheadOfTime(isolate); 736 ArrayConstructorStubBase::GenerateStubsAheadOfTime(isolate);
737 } 737 }
738 738
739 739
740 } } // namespace v8::internal 740 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/simulator-arm.cc ('k') | src/ia32/code-stubs-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698