src/arm/simulator-arm.cc - Issue 14813029: Error found in test262 on ARM: BinaryOpStub could call out to a built-in and push …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/simulator-arm.cc

Issue 14813029: Error found in test262 on ARM: BinaryOpStub could call out to a built-in and push … (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Code review comments Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/simulator-arm.cc

diff --git a/src/arm/simulator-arm.cc b/src/arm/simulator-arm.cc

index af65bc70bd247368ecfc61d6c06c1333dd7ce2f0..e91f079c3a4e611ccbbfd6256edb98ba4fa94a13 100644

--- a/src/arm/simulator-arm.cc

+++ b/src/arm/simulator-arm.cc

@@ -412,7 +412,7 @@ void ArmDebugger::Debug() {

HeapObject* obj = reinterpret_cast<HeapObject*>(*cur);

int value = *cur;

Heap* current_heap = v8::internal::Isolate::Current()->heap();

- if (current_heap->Contains(obj) || ((value & 1) == 0)) {

+ if (((value & 1) == 0) || current_heap->Contains(obj)) {

PrintF(" (");

if ((value & 1) == 0) {

PrintF("smi %d", value / 2);

« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »