Deleted fullscreen virtual methods in BrowserWindow.

Deleted fullscreen virtual methods in BrowserWindow.

These methods are not actually used. Methods of identical names/types
exist in ExclusiveAccessContext. BrowserView inherits both BrowserWindow
and ExclusiveAccessContext and double-overrides this method. It is only
virtual-dispatched through ExclusiveAccessContext, so the BrowserWindow
virtual methods do not need to exist.

Updated tests that were depending on this old interface.

BUG=352425
Committed: https://crrev.com/9354355f3cad54c89e4d217a848e553d4de09cad
Cr-Commit-Position: refs/heads/master@{#362926}

[Matt Giuca, 2015-11-29 23:40:52]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-29 23:40:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480183002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480183002/1

[commit-bot: I haz the power, 2015-11-29 23:49:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-29 23:49:37]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Matt Giuca, 2015-11-30 05:00:04]

Patchset #2 (id:20001) has been deleted

[Matt Giuca, 2015-11-30 05:01:16]

Description was changed from

==========
Deleted fullscreen virtual methods in BrowserWindow.

These methods are not actually used. Methods of identical names/types
exist in ExclusiveAccessContext. BrowserView inherits both BrowserWindow
and ExclusiveAccessContext and double-overrides this method. It is only
virtual-dispatched through ExclusiveAccessContext, so the BrowserWindow
virtual methods do not need to exist.

BUG=352425
==========

to

==========
Deleted fullscreen virtual methods in BrowserWindow.

These methods are not actually used. Methods of identical names/types
exist in ExclusiveAccessContext. BrowserView inherits both BrowserWindow
and ExclusiveAccessContext and double-overrides this method. It is only
virtual-dispatched through ExclusiveAccessContext, so the BrowserWindow
virtual methods do not need to exist.

Updated tests that were depending on this old interface.

BUG=352425
==========

[Matt Giuca, 2015-11-30 05:37:15]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-30 05:37:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480183002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480183002/40001

[commit-bot: I haz the power, 2015-11-30 05:48:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-30 05:48:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Matt Giuca, 2015-11-30 06:01:16]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-30 06:02:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480183002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480183002/60001

[commit-bot: I haz the power, 2015-11-30 06:04:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-30 06:04:43]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Matt Giuca, 2015-12-01 03:12:30]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-01 03:13:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480183002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480183002/60001

[commit-bot: I haz the power, 2015-12-01 03:40:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-01 03:40:34]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Matt Giuca, 2015-12-02 02:03:20]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-02 02:07:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480183002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480183002/120001

[commit-bot: I haz the power, 2015-12-02 02:24:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-02 02:24:40]

Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[Matt Giuca, 2015-12-02 03:00:57]

mgiuca@chromium.org changed reviewers:
+ benwells@chromium.org, msw@chromium.org, phajdan.jr@chromium.org

[Matt Giuca, 2015-12-02 03:00:58]

benwells: Please review changes in extension_fullscreen_apitest.cc.

phajdan.jr: Please review changes in test_browser_window.h.

msw: Please review changes in chrome/browser/ui/*.

[Paweł Hajdan Jr., 2015-12-02 09:27:31]

chrome/test LGTM

[Matt Giuca, 2015-12-02 23:19:15]

mgiuca@chromium.org changed reviewers:
+ pkasting@chromium.org

[Matt Giuca, 2015-12-02 23:19:15]

+pkasting for changes in chrome/browser/ui/* since msw is away.

[Peter Kasting, 2015-12-03 04:39:11]

LGTM

https://codereview.chromium.org/1480183002/diff/120001/chrome/browser/ui/excl...
File chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc
(right):

https://codereview.chromium.org/1480183002/diff/120001/chrome/browser/ui/excl...
chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc:66:
void ExitFullscreen() override;
Also move the definitions of these functions to match the reordered
declarations.

[benwells, 2015-12-03 06:39:34]

lgtm, nice

[Matt Giuca, 2015-12-03 06:42:59]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2015-12-03 06:43:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480183002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480183002/120001

[commit-bot: I haz the power, 2015-12-03 07:24:56]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2015-12-03 07:25:51]

Description was changed from

==========
Deleted fullscreen virtual methods in BrowserWindow.

These methods are not actually used. Methods of identical names/types
exist in ExclusiveAccessContext. BrowserView inherits both BrowserWindow
and ExclusiveAccessContext and double-overrides this method. It is only
virtual-dispatched through ExclusiveAccessContext, so the BrowserWindow
virtual methods do not need to exist.

Updated tests that were depending on this old interface.

BUG=352425
==========

to

==========
Deleted fullscreen virtual methods in BrowserWindow.

These methods are not actually used. Methods of identical names/types
exist in ExclusiveAccessContext. BrowserView inherits both BrowserWindow
and ExclusiveAccessContext and double-overrides this method. It is only
virtual-dispatched through ExclusiveAccessContext, so the BrowserWindow
virtual methods do not need to exist.

Updated tests that were depending on this old interface.

BUG=352425

Committed: https://crrev.com/9354355f3cad54c89e4d217a848e553d4de09cad
Cr-Commit-Position: refs/heads/master@{#362926}
==========

[commit-bot: I haz the power, 2015-12-03 07:25:51]

Patchset 6 (id:??) landed as
https://crrev.com/9354355f3cad54c89e4d217a848e553d4de09cad
Cr-Commit-Position: refs/heads/master@{#362926}