Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 1483893002: Various fixes for ExtensionApiTest. (Closed)

Created:
5 years ago by Matt Giuca
Modified:
5 years ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Various fixes for ExtensionApiTest. - Re-enable test UpdateWindowSizeExitsFullscreen on non-Mac platforms. - FocusWindowDoesNotExitFullscreen: Assert that we actually went to fullscreen mode. (Previously this test would happily pass if entering fullscreen fails for some reason.) BUG=308041 Committed: https://crrev.com/75dacc22e7914fecaaf28916aa3233a87e3bc8bc Cr-Commit-Position: refs/heads/master@{#362094}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/browser/extensions/extension_fullscreen_apitest.cc View 1 chunk +10 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Matt Giuca
5 years ago (2015-11-30 05:00:36 UTC) #2
benwells
lgtm
5 years ago (2015-11-30 05:11:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1483893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1483893002/1
5 years ago (2015-11-30 05:37:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 06:03:37 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-30 06:04:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75dacc22e7914fecaaf28916aa3233a87e3bc8bc
Cr-Commit-Position: refs/heads/master@{#362094}

Powered by Google App Engine
This is Rietveld 408576698